Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new GitHub Action to auto-assign PR reviewers #2175

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Conversation

na--
Copy link
Member

@na-- na-- commented Oct 12, 2021

This should hopefully automatically assign reviewers when a PR is opened, though it will probably only work when we merge it in master...

@na--
Copy link
Member Author

na-- commented Oct 12, 2021

Or not 🎉 worked even from the branch, though I guess I need to adjust numberOfReviewers to 1 😅

Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we better add a skip option to prevent assigning WIP PRs:

# A list of keywords to be skipped the process that add reviewers if pull requests include it
skipKeywords:
    - wip

@na-- na-- force-pushed the pr-auto-assign branch 2 times, most recently from 4d276ff to 9fb54f0 Compare October 12, 2021 07:27
@na-- na-- requested a review from inancgumus October 12, 2021 07:27
@inancgumus
Copy link
Member

inancgumus commented Oct 12, 2021

@inancgumus
Copy link
Member

I requested a feature :)

kentaro-m/auto-assign-action#57

@na--
Copy link
Member Author

na-- commented Oct 12, 2021

@inancgumus, I think this only means that GitHub will automatically assign reviewers for PRs that originate from the team to other members of the team:

This will automatically route this team's code review requests to individual team members.

Which is not a problem for us, since we can already manually assign appropriate people to PRs when we open them. We mostly need this for external PRs

Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use addAssignees: author?

- yorugac
- inancgumus
skipKeywords:
- wip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have Draft PR for that, or not?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use addAssignees: author?

I don't think this would add anything, the author of a PR is the one that works on it by default

Do we have Draft PR for that, or not?

We do, but not everyone always remembers to use it, so checking for WIP is probably a nice idea. And draft PRs are why this gets executed on the ready_for_review event as well.

Comment on lines +5 to +14
numberOfReviewers: 1
reviewGroups:
old:
- na--
- MStoykov
- imiric
new: # TODO: remove a few months from now
- codebien
- yorugac
- inancgumus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not very clear from the documentation, but I guess this will pick 1 reviewer from each group at random?

Sounds good 👍

@na-- na-- merged commit 370254c into master Oct 12, 2021
@na-- na-- deleted the pr-auto-assign branch October 12, 2021 08:02
@mstoykov mstoykov added this to the v0.35.0 milestone Oct 26, 2021
@na-- na-- mentioned this pull request Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants