-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new GitHub Action to auto-assign PR reviewers #2175
Conversation
Or not 🎉 worked even from the branch, though I guess I need to adjust |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we better add a skip
option to prevent assigning WIP PRs:
# A list of keywords to be skipped the process that add reviewers if pull requests include it
skipKeywords:
- wip
4d276ff
to
9fb54f0
Compare
Does Github automatically assign reviewers? 🤔 |
I requested a feature :) |
@inancgumus, I think this only means that GitHub will automatically assign reviewers for PRs that originate from the team to other members of the team:
Which is not a problem for us, since we can already manually assign appropriate people to PRs when we open them. We mostly need this for external PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use addAssignees: author
?
- yorugac | ||
- inancgumus | ||
skipKeywords: | ||
- wip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have Draft PR for that, or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use
addAssignees: author
?
I don't think this would add anything, the author of a PR is the one that works on it by default
Do we have Draft PR for that, or not?
We do, but not everyone always remembers to use it, so checking for WIP
is probably a nice idea. And draft PRs are why this gets executed on the ready_for_review
event as well.
numberOfReviewers: 1 | ||
reviewGroups: | ||
old: | ||
- na-- | ||
- MStoykov | ||
- imiric | ||
new: # TODO: remove a few months from now | ||
- codebien | ||
- yorugac | ||
- inancgumus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not very clear from the documentation, but I guess this will pick 1 reviewer from each group at random?
Sounds good 👍
This should hopefully automatically assign reviewers when a PR is opened, though it will probably only work when we merge it in
master
...