Adds the K6_INFLUXDB_PROXY environment variable support, closes #3418

[IvanovOleg]

What?

This PR closes #3418 by adding the K6_INFLUXDB_PROXY environment variable support.

Why?

This PR fixes the problem when your InfluxDB server is not opened for direct connections and requires a connection through proxy.

Checklist

• I have performed a self-review of my code.
• I have added tests for my changes.
• I have run linter locally (make lint) and all checks pass.
• I have run tests locally (make tests) and all tests pass.
• I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Closes #3418

[CLAassistant]

All committers have signed the CLA.

[IvanovOleg]

I ran tests and only timeout test has failed, also fails when executed from the master branch so I doubt it has anything to do with my changes. I didn't comment anything since my change is really small and obvious.

[mstoykov]

LGTM in general, thanks 🙇

But can you change the way it is set currently, and I would prefer if we have at least one config test. And if possible actually test the proxying?

I also saw that you didn't change it to be parsable from the cli directly (see ParseURL in the config.go).

I am not certain how good of an idea is to support this ... given that I think it will need to be escaped quite a lot. So I kind of don't think you need to do it , but let's see what @codebien thinks as well

[codecov-commenter]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8e2c27a) 73.33% compared to head (437bc30) 73.27%.
Report is 4 commits behind head on master.

❗ Current head 437bc30 differs from pull request most recent head d8e9b0a. Consider uploading reports for the commit d8e9b0a to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3423      +/-   ##
==========================================
- Coverage   73.33%   73.27%   -0.07%     
==========================================
  Files         258      256       -2     
  Lines       19645    19646       +1     
==========================================
- Hits        14407    14395      -12     
- Misses       4353     4361       +8     
- Partials      885      890       +5     

Flag	Coverage Δ
ubuntu	73.27% <87.50%> (-0.01%)	⬇️
windows	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
output/influxdb/config.go	50.96% <100.00%> (+0.96%)	⬆️
output/influxdb/util.go	78.43% <83.33%> (-0.30%)	⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codebien]

I also saw that you didn't change it to be parsable from the cli directly (see ParseURL in the config.go).

@mstoykov Yeah, I would prefer if we avoid it. An URL in another URL doesn't sound like the best UX.

[codebien]

As @mstoykov reported, we should add a test for it.

[codebien]

Suggested change

	Proxy null.String `json:"proxy,omitempty" envconfig:"K6_INFLUXDB_PROXY"`
	Proxy null.String `json:"proxy,omitempty" envconfig:"K6_INFLUXDB_HTTP_PROXY"`

@IvanovOleg @mstoykov WDYT? Should we do it? I like the consistency with the original HTTP_PROXY variable, but on the other side, I'm not sure because it could introduce confusion around the expected HTTP/S value.

[IvanovOleg]

I can change the name as you suggested, no problem. The reason I named it like that because it will work with http and https at the same time

[IvanovOleg]

Added a config test for the K6_INFLUXDB_PROXY variable.

[codebien]

@mstoykov I checked the returned UX in case of error and it seems fine to me.

ERRO[0000] could not create the 'influxdb' output: failed to parse the http proxy URL: parse "http://foo\x7f.com/": net/url: invalid control character in URL

[mstoykov]

Thanks for this change @IvanovOleg