Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint: Disable forcetypeassert for tests #3704

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Apr 22, 2024

What?

Disable forcetypeassert on tests.

Why?

It seems most core developers agree this isn't really a good linter for tests and makes a lot of them more complicated or longer.

see #3701 (comment)

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v0.51.0 milestone Apr 22, 2024
@mstoykov mstoykov requested a review from a team as a code owner April 22, 2024 12:54
@mstoykov mstoykov requested review from oleiade and joanlopez and removed request for a team April 22, 2024 12:54
@mstoykov mstoykov mentioned this pull request Apr 22, 2024
5 tasks
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.24%. Comparing base (d7b37b3) to head (1e1f94b).

❗ Current head 1e1f94b differs from pull request most recent head 64e4aac. Consider uploading reports for the commit 64e4aac to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3704      +/-   ##
==========================================
+ Coverage   73.22%   73.24%   +0.01%     
==========================================
  Files         276      276              
  Lines       20384    20384              
==========================================
+ Hits        14926    14930       +4     
+ Misses       4502     4498       -4     
  Partials      956      956              
Flag Coverage Δ
ubuntu 73.24% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

joanlopez
joanlopez previously approved these changes Apr 22, 2024
codebien
codebien previously approved these changes Apr 23, 2024
olegbespalov
olegbespalov previously approved these changes Apr 23, 2024
Base automatically changed from lintFixes to master April 23, 2024 14:16
@mstoykov mstoykov dismissed stale reviews from olegbespalov, codebien, and joanlopez April 23, 2024 14:16

The base branch was changed.

@mstoykov mstoykov force-pushed the dropForceTypeAssertForTests branch from d5be7db to 64e4aac Compare April 23, 2024 14:17
@mstoykov mstoykov requested a review from joanlopez April 23, 2024 15:10
@mstoykov mstoykov merged commit b866c10 into master Apr 23, 2024
22 checks passed
@mstoykov mstoykov deleted the dropForceTypeAssertForTests branch April 23, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants