Global timers #3706
Merged
Global timers #3706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
requested review from
oleiade and
joanlopez
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3706 +/- ##
==========================================
- Coverage 73.30% 73.26% -0.05%
==========================================
Files 278 278
Lines 20389 20398 +9
==========================================
- Hits 14947 14945 -2
- Misses 4492 4501 +9
- Partials 950 952 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mstoykov
added
the
documentation-needed
joanlopez
reviewed
Apr 26, 2024
| "clearTimeout": e.clearTimeout, | ||
| "setInterval": e.setInterval, | ||
| "clearInterval": e.clearInterval, | ||
| // TODO the usage of `ToValue` here is so that goja doesn't do it automatically later |
There was a problem hiding this comment.
Nit; I don't fully get what's pending "to do" here based on this comment 🤔
There was a problem hiding this comment.
This is a workaround for #3707
Maybe TODO isn't the best option here 🤔
joanlopez
approved these changes
Apr 26, 2024
oleiade
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Make k6/timers globally available
Why?
This is in general what most users expect - just being able to use
setTimeoutdirectly.Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
#3589