-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Summary Generated Events #3730
Changes from all commits
b88ca8a
91c9b44
bc5b8c4
a603817
bc4a1d8
687e85d
f33429c
8756b80
32b6c1e
c31b30a
6a53f4e
ed4a8f6
ae92ab8
57b3cad
12b5dd1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -99,3 +99,8 @@ type Summary struct { | |
NoColor bool // TODO: drop this when noColor is part of the (runtime) options | ||
UIState UIState | ||
} | ||
|
||
// String Overiding for tests | ||
func (s *Summary) String() string { | ||
return "&{Summary:map[...]...}" | ||
} | ||
Comment on lines
+104
to
+106
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess when we agree on the generation part then we should update this with some additional information. We might have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be better to copy ObservedMetrics and RootGroup instead of directly passing them. They are pointers and they might generate data races if there is a read/write across extensions and/or from k6core.