Revert "Added summary generated event" #3736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit eec9105.
olegbespalov
requested review from
codebien and
joanlopez
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3736 +/- ##
==========================================
- Coverage 70.85% 70.83% -0.02%
==========================================
Files 289 289
Lines 21164 21159 -5
==========================================
- Hits 14996 14989 -7
- Misses 5211 5213 +2
Partials 957 957
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced May 9, 2024
Merged
joanlopez
approved these changes
May 13, 2024
codebien
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
After an internal team discussion, keeping in mind #3730, we decided to revert #3682 and not include it in the upcoming v0.51 release.
Why?
We want to avoid introducing things that will be changed straight after and, on the other side, have unfortunately no capacity to get the #3730 into an upcoming release
cc: @ameetpal