operator: Add warning for old schema configuration

operator/CHANGELOG.md

@@ -1,5 +1,6 @@
 ## Main
 
+- [11158](https://github.com/grafana/loki/pull/11158) **btaani**: operator: Add warning for old schema configuration
 - [11473](https://github.com/grafana/loki/pull/11473) **JoaoBraveCoding**: Adds structured metadata dashboards
 - [11448](https://github.com/grafana/loki/pull/11448) **periklis**: Update Loki operand to v2.9.3
 - [11357](https://github.com/grafana/loki/pull/11357) **periklis**: Fix storing authentication credentials in the Loki ConfigMap

operator/apis/loki/v1/lokistack_types.go

@@ -1041,6 +1041,10 @@ const (
 	// ConditionDegraded defines the condition that some or all components in the Loki deployment
 	// are degraded or the cluster cannot connect to object storage.
 	ConditionDegraded LokiStackConditionType = "Degraded"
+
+	// ConditionWarning is used for configurations that are not recommended, but don't currently cause
+	// issues. There can be multiple warning conditions active at a time.
+	ConditionWarning LokiStackConditionType = "Warning"
 )
 
 // LokiStackConditionReason defines the type for valid reasons of a Loki deployment conditions.
@@ -1097,6 +1101,8 @@ const (
 	ReasonZoneAwareNodesMissing LokiStackConditionReason = "ReasonZoneAwareNodesMissing"
 	// ReasonZoneAwareEmptyLabel when the node-label used for zone-awareness has an empty value.
 	ReasonZoneAwareEmptyLabel LokiStackConditionReason = "ReasonZoneAwareEmptyLabel"
+	// ReasonStorageNeedsSchemaUpdate when the object storage schema version is older than V13
+	ReasonStorageNeedsSchemaUpdate LokiStackConditionReason = "StorageNeedsSchemaUpdate"
 )
 
 // PodStatusMap defines the type for mapping pod status to pod name.

operator/controllers/loki/lokistack_controller.go

@@ -5,7 +5,6 @@ import (
 	"errors"
 	"time"
 
-	"github.com/ViaQ/logerr/v2/kverrors"
 	"github.com/go-logr/logr"
 	"github.com/google/go-cmp/cmp"
 	openshiftconfigv1 "github.com/openshift/api/config/v1"
@@ -150,40 +149,41 @@ func (r *LokiStackReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
 		return ctrl.Result{}, nil
 	}
 
-	if r.FeatureGates.BuiltInCertManagement.Enabled {
-		err = handlers.CreateOrRotateCertificates(ctx, r.Log, req, r.Client, r.Scheme, r.FeatureGates)
-		if err != nil {
-			return handleDegradedError(ctx, r.Client, req, err)
-		}
+	var degraded *status.DegradedError
+	err = r.updateResources(ctx, req)
+	switch {
+	case errors.As(err, &degraded):
+	// degraded errors are handled by status.Refresh below
+	case err != nil:
+		return ctrl.Result{}, err
 	}
 
-	err = handlers.CreateOrUpdateLokiStack(ctx, r.Log, req, r.Client, r.Scheme, r.FeatureGates)
+	err = status.Refresh(ctx, r.Client, req, time.Now(), degraded)
 	if err != nil {
-		return handleDegradedError(ctx, r.Client, req, err)
+		return ctrl.Result{}, err
 	}
 
-	err = status.Refresh(ctx, r.Client, req, time.Now())
-	if err != nil {
-		return ctrl.Result{}, err
+	if degraded != nil {
+		return ctrl.Result{
+			Requeue: degraded.Requeue,
+		}, nil
 	}
 
 	return ctrl.Result{}, nil
 }
 
-func handleDegradedError(ctx context.Context, c client.Client, req ctrl.Request, err error) (ctrl.Result, error) {
-	var degraded *status.DegradedError
-	if errors.As(err, &degraded) {
-		err = status.SetDegradedCondition(ctx, c, req, degraded.Message, degraded.Reason)
-		if err != nil {
-			return ctrl.Result{}, kverrors.Wrap(err, "error setting degraded condition")
+func (r *LokiStackReconciler) updateResources(ctx context.Context, req ctrl.Request) error {
+	if r.FeatureGates.BuiltInCertManagement.Enabled {
+		if err := handlers.CreateOrRotateCertificates(ctx, r.Log, req, r.Client, r.Scheme, r.FeatureGates); err != nil {
+			return err
 		}
+	}
 
-		return ctrl.Result{
-			Requeue: degraded.Requeue,
-		}, nil
+	if err := handlers.CreateOrUpdateLokiStack(ctx, r.Log, req, r.Client, r.Scheme, r.FeatureGates); err != nil {
+		return err
 	}
 
-	return ctrl.Result{}, err
+	return nil
 }
 
 // SetupWithManager sets up the controller with the Manager.

operator/docs/operator/api.md

@@ -1780,6 +1780,9 @@ for the ruler is missing.</p>
 </tr><tr><td><p>&#34;ReadyComponents&#34;</p></td>
 <td><p>ReasonReadyComponents when all LokiStack components are ready to serve traffic.</p>
 </td>
+</tr><tr><td><p>&#34;StorageNeedsSchemaUpdate&#34;</p></td>
+<td><p>ReasonStorageNeedsSchemaUpdate when the object storage schema version is older than V13</p>
+</td>
 </tr><tr><td><p>&#34;ReasonZoneAwareEmptyLabel&#34;</p></td>
 <td><p>ReasonZoneAwareEmptyLabel when the node-label used for zone-awareness has an empty value.</p>
 </td>
@@ -1814,6 +1817,10 @@ are degraded or the cluster cannot connect to object storage.</p>
 </tr><tr><td><p>&#34;Ready&#34;</p></td>
 <td><p>ConditionReady defines the condition that all components in the Loki deployment are ready.</p>
 </td>
+</tr><tr><td><p>&#34;Warning&#34;</p></td>
+<td><p>ConditionWarning is used for configurations that are not recommended, but don&rsquo;t currently cause
+issues. There can be multiple warning conditions active at a time.</p>
+</td>
 </tr></tbody>
 </table>