Remove bloomcompactor.DayTable in favour of config.DayTime
#11917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
force-pushed
the
chaudum/bloomgateway-use-daytable
branch
from
05f7c72 to
378a903
Compare
chaudum
force-pushed
the
chaudum/bloomgateway-use-daytable
branch
from
378a903 to
9ae6a2e
Compare
|
We should remove |
chaudum
force-pushed
the
chaudum/bloomgateway-use-daytable
branch
from
9ae6a2e to
85ed7b2
Compare
chaudum
changed the title
bloomcompactor.DayTable in bloom gateway codebloomcompactor.DayTable in favour of config.DayTime
chaudum
force-pushed
the
chaudum/bloomgateway-use-daytable
branch
from
4171751 to
d9d2895
Compare
Where previously a model.Time was used to define the day of a task. Signed-off-by: Christian Haudum <[email protected]>
chaudum
force-pushed
the
chaudum/bloomgateway-use-daytable
branch
from
d9d2895 to
b841401
Compare
Signed-off-by: Christian Haudum <[email protected]>
chaudum
force-pushed
the
chaudum/bloomgateway-use-daytable
branch
from
b841401 to
cf2aa90
Compare
salvacorts
approved these changes
Feb 13, 2024
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…na#11917) Both structs shared the same semantics. This PR moves additional functionality from the `DayTable` to the `DayTime` struct. To get the table name of a day (ordinal number of day since unix epoch), call `DayTime.Table()`. Signed-off-by: Christian Haudum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where previously a
model.Timewas used to define the day of a task.