Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helm: Add validation that checks for empty bucket configuration #14843

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

DylanGuedes
Copy link
Contributor

What this PR does / why we need it:
We removed the possibility of running the chart by default without setting any bucket configuration, as this can lead to security incidents (you could end up sending your data to a bucket you don't have access to).
However, the error message isn't clear on that. This PR fixes it by throwing a more explicit error.
I'm putting it inside that define block because that block is being evaluated before our templates/validate code is triggered.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@DylanGuedes DylanGuedes requested a review from a team as a code owner November 8, 2024 12:15
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Nov 8, 2024

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Kubernetes Manifest Diff Summary

Scenario: default-single-binary-values (Added: 0, Modified: 11, Removed: 0)

Summary:

  • Added: 0

  • Modified: 11

  • Removed: 0

Added Files

No added files

Modified Files

loki/templates/querier/deployment-querier.yaml
*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/querier/deployment-querier.yaml	2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/querier/deployment-querier.yaml	2024-11-08 17:22:26.806292200 +0000
***************
*** 28,34 ****
 template:
 metadata:
 annotations:
! checksum/config: 8afd86b031d6b47b96a59259a9e3393a95d5b321e5b9f5b492a2880b96042d52
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
--- 28,34 ----
 template:
 metadata:
 annotations:
! checksum/config: 1586195cf9cfc78f6a555943e6e87dc841b20b40ed9aaa740cf2353be32247ac
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
loki/templates/query-frontend/deployment-query-frontend.yaml
*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/query-frontend/deployment-query-frontend.yaml	2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/query-frontend/deployment-query-frontend.yaml	2024-11-08 17:22:26.806292200 +0000
***************
*** 27,33 ****
 template:
 metadata:
 annotations:
! checksum/config: 8afd86b031d6b47b96a59259a9e3393a95d5b321e5b9f5b492a2880b96042d52
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
--- 27,33 ----
 template:
 metadata:
 annotations:
! checksum/config: 1586195cf9cfc78f6a555943e6e87dc841b20b40ed9aaa740cf2353be32247ac
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
loki/templates/compactor/statefulset-compactor.yaml
*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/compactor/statefulset-compactor.yaml	2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/compactor/statefulset-compactor.yaml	2024-11-08 17:22:26.810292222 +0000
***************
*** 29,35 ****
 template:
 metadata:
 annotations:
! checksum/config: 8afd86b031d6b47b96a59259a9e3393a95d5b321e5b9f5b492a2880b96042d52
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
--- 29,35 ----
 template:
 metadata:
 annotations:
! checksum/config: 1586195cf9cfc78f6a555943e6e87dc841b20b40ed9aaa740cf2353be32247ac
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
loki/templates/config.yaml
*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/config.yaml	2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/config.yaml	2024-11-08 17:22:26.806292200 +0000
***************
*** 14,20 ****
 data:
 config.yaml: |
 
! auth_enabled: true
 bloom_build:
 builder:
 planner_address: loki-test-chart-name-bloom-planner-headless.default.svc.cluster.local:9095
--- 14,20 ----
 data:
 config.yaml: |
 
! map[chunks:chunks ruler:ruler]auth_enabled: true
 bloom_build:
 builder:
 planner_address: loki-test-chart-name-bloom-planner-headless.default.svc.cluster.local:9095
loki/templates/query-scheduler/deployment-query-scheduler.yaml
*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/query-scheduler/deployment-query-scheduler.yaml	2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/query-scheduler/deployment-query-scheduler.yaml	2024-11-08 17:22:26.806292200 +0000
***************
*** 27,33 ****
 template:
 metadata:
 annotations:
! checksum/config: 8afd86b031d6b47b96a59259a9e3393a95d5b321e5b9f5b492a2880b96042d52
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
--- 27,33 ----
 template:
 metadata:
 annotations:
! checksum/config: 1586195cf9cfc78f6a555943e6e87dc841b20b40ed9aaa740cf2353be32247ac
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
loki/templates/ruler/statefulset-ruler.yaml
*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/ruler/statefulset-ruler.yaml	2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/ruler/statefulset-ruler.yaml	2024-11-08 17:22:26.810292222 +0000
***************
*** 24,30 ****
 template:
 metadata:
 annotations:
! checksum/config: 8afd86b031d6b47b96a59259a9e3393a95d5b321e5b9f5b492a2880b96042d52
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
--- 24,30 ----
 template:
 metadata:
 annotations:
! checksum/config: 1586195cf9cfc78f6a555943e6e87dc841b20b40ed9aaa740cf2353be32247ac
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
loki/templates/index-gateway/statefulset-index-gateway.yaml
*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/index-gateway/statefulset-index-gateway.yaml	2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/index-gateway/statefulset-index-gateway.yaml	2024-11-08 17:22:26.810292222 +0000
***************
*** 25,31 ****
 template:
 metadata:
 annotations:
! checksum/config: 8afd86b031d6b47b96a59259a9e3393a95d5b321e5b9f5b492a2880b96042d52
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
--- 25,31 ----
 template:
 metadata:
 annotations:
! checksum/config: 1586195cf9cfc78f6a555943e6e87dc841b20b40ed9aaa740cf2353be32247ac
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
loki/templates/ingester/statefulset-ingester-zone-c.yaml
*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-c.yaml	2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-c.yaml	2024-11-08 17:22:26.810292222 +0000
***************
*** 34,40 ****
 template:
 metadata:
 annotations:
! checksum/config: 8afd86b031d6b47b96a59259a9e3393a95d5b321e5b9f5b492a2880b96042d52
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
--- 34,40 ----
 template:
 metadata:
 annotations:
! checksum/config: 1586195cf9cfc78f6a555943e6e87dc841b20b40ed9aaa740cf2353be32247ac
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
loki/templates/ingester/statefulset-ingester-zone-b.yaml
*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-b.yaml	2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-b.yaml	2024-11-08 17:22:26.810292222 +0000
***************
*** 34,40 ****
 template:
 metadata:
 annotations:
! checksum/config: 8afd86b031d6b47b96a59259a9e3393a95d5b321e5b9f5b492a2880b96042d52
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
--- 34,40 ----
 template:
 metadata:
 annotations:
! checksum/config: 1586195cf9cfc78f6a555943e6e87dc841b20b40ed9aaa740cf2353be32247ac
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
loki/templates/ingester/statefulset-ingester-zone-a.yaml
*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-a.yaml	2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-a.yaml	2024-11-08 17:22:26.810292222 +0000
***************
*** 34,40 ****
 template:
 metadata:
 annotations:
! checksum/config: 8afd86b031d6b47b96a59259a9e3393a95d5b321e5b9f5b492a2880b96042d52
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
--- 34,40 ----
 template:
 metadata:
 annotations:
! checksum/config: 1586195cf9cfc78f6a555943e6e87dc841b20b40ed9aaa740cf2353be32247ac
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
loki/templates/distributor/deployment-distributor.yaml
*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/distributor/deployment-distributor.yaml	2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/distributor/deployment-distributor.yaml	2024-11-08 17:22:26.806292200 +0000
***************
*** 28,34 ****
 template:
 metadata:
 annotations:
! checksum/config: 8afd86b031d6b47b96a59259a9e3393a95d5b321e5b9f5b492a2880b96042d52
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
--- 28,34 ----
 template:
 metadata:
 annotations:
! checksum/config: 1586195cf9cfc78f6a555943e6e87dc841b20b40ed9aaa740cf2353be32247ac
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name

Removed Files

No removed files

Scenario: default-values (Added: 0, Modified: 4, Removed: 0)

Summary:

  • Added: 0

  • Modified: 4

  • Removed: 0

Added Files

No added files

Modified Files

loki/templates/read/deployment-read.yaml
*** /home/runner/work/loki/loki/output/base/default-values/loki/templates/read/deployment-read.yaml	2024-11-08 17:22:24.566280037 +0000
--- /home/runner/work/loki/loki/output/pr/default-values/loki/templates/read/deployment-read.yaml	2024-11-08 17:22:26.902292722 +0000
***************
*** 28,34 ****
 template:
 metadata:
 annotations:
! checksum/config: 540324ec0074bd0542be3e9a36892034c213d8576418c25ef5dd4443df6b354f
 labels:
 app.kubernetes.io/part-of: memberlist
 app.kubernetes.io/name: loki
--- 28,34 ----
 template:
 metadata:
 annotations:
! checksum/config: 0f9b18140fe2d1a072eacec48cbcc71c660b410bac12421fd6931ae4c1495dd0
 labels:
 app.kubernetes.io/part-of: memberlist
 app.kubernetes.io/name: loki
loki/templates/config.yaml
*** /home/runner/work/loki/loki/output/base/default-values/loki/templates/config.yaml	2024-11-08 17:22:24.566280037 +0000
--- /home/runner/work/loki/loki/output/pr/default-values/loki/templates/config.yaml	2024-11-08 17:22:26.902292722 +0000
***************
*** 14,20 ****
 data:
 config.yaml: |
 
! auth_enabled: true
 bloom_build:
 builder:
 planner_address: loki-backend-headless.default.svc.cluster.local:9095
--- 14,20 ----
 data:
 config.yaml: |
 
! map[admin:admin chunks:chunks ruler:ruler]auth_enabled: true
 bloom_build:
 builder:
 planner_address: loki-backend-headless.default.svc.cluster.local:9095
loki/templates/write/statefulset-write.yaml
*** /home/runner/work/loki/loki/output/base/default-values/loki/templates/write/statefulset-write.yaml	2024-11-08 17:22:24.566280037 +0000
--- /home/runner/work/loki/loki/output/pr/default-values/loki/templates/write/statefulset-write.yaml	2024-11-08 17:22:26.902292722 +0000
***************
*** 29,35 ****
 template:
 metadata:
 annotations:
! checksum/config: 540324ec0074bd0542be3e9a36892034c213d8576418c25ef5dd4443df6b354f
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
--- 29,35 ----
 template:
 metadata:
 annotations:
! checksum/config: 0f9b18140fe2d1a072eacec48cbcc71c660b410bac12421fd6931ae4c1495dd0
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
loki/templates/backend/statefulset-backend.yaml
*** /home/runner/work/loki/loki/output/base/default-values/loki/templates/backend/statefulset-backend.yaml	2024-11-08 17:22:24.566280037 +0000
--- /home/runner/work/loki/loki/output/pr/default-values/loki/templates/backend/statefulset-backend.yaml	2024-11-08 17:22:26.902292722 +0000
***************
*** 33,39 ****
 template:
 metadata:
 annotations:
! checksum/config: 540324ec0074bd0542be3e9a36892034c213d8576418c25ef5dd4443df6b354f
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
--- 33,39 ----
 template:
 metadata:
 annotations:
! checksum/config: 0f9b18140fe2d1a072eacec48cbcc71c660b410bac12421fd6931ae4c1495dd0
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name

Removed Files

No removed files

Scenario: ingress-values (Added: 0, Modified: 4, Removed: 0)

Summary:

  • Added: 0

  • Modified: 4

  • Removed: 0

Added Files

No added files

Modified Files

loki/templates/read/deployment-read.yaml
*** /home/runner/work/loki/loki/output/base/ingress-values/loki/templates/read/deployment-read.yaml	2024-11-08 17:22:24.662280558 +0000
--- /home/runner/work/loki/loki/output/pr/ingress-values/loki/templates/read/deployment-read.yaml	2024-11-08 17:22:27.002293265 +0000
***************
*** 28,34 ****
 template:
 metadata:
 annotations:
! checksum/config: 540324ec0074bd0542be3e9a36892034c213d8576418c25ef5dd4443df6b354f
 labels:
 app.kubernetes.io/part-of: memberlist
 app.kubernetes.io/name: loki
--- 28,34 ----
 template:
 metadata:
 annotations:
! checksum/config: 0f9b18140fe2d1a072eacec48cbcc71c660b410bac12421fd6931ae4c1495dd0
 labels:
 app.kubernetes.io/part-of: memberlist
 app.kubernetes.io/name: loki
loki/templates/config.yaml
*** /home/runner/work/loki/loki/output/base/ingress-values/loki/templates/config.yaml	2024-11-08 17:22:24.658280537 +0000
--- /home/runner/work/loki/loki/output/pr/ingress-values/loki/templates/config.yaml	2024-11-08 17:22:26.998293243 +0000
***************
*** 14,20 ****
 data:
 config.yaml: |
 
! auth_enabled: true
 bloom_build:
 builder:
 planner_address: loki-backend-headless.default.svc.cluster.local:9095
--- 14,20 ----
 data:
 config.yaml: |
 
! map[admin:admin chunks:chunks ruler:ruler]auth_enabled: true
 bloom_build:
 builder:
 planner_address: loki-backend-headless.default.svc.cluster.local:9095
loki/templates/write/statefulset-write.yaml
*** /home/runner/work/loki/loki/output/base/ingress-values/loki/templates/write/statefulset-write.yaml	2024-11-08 17:22:24.662280558 +0000
--- /home/runner/work/loki/loki/output/pr/ingress-values/loki/templates/write/statefulset-write.yaml	2024-11-08 17:22:27.002293265 +0000
***************
*** 29,35 ****
 template:
 metadata:
 annotations:
! checksum/config: 540324ec0074bd0542be3e9a36892034c213d8576418c25ef5dd4443df6b354f
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
--- 29,35 ----
 template:
 metadata:
 annotations:
! checksum/config: 0f9b18140fe2d1a072eacec48cbcc71c660b410bac12421fd6931ae4c1495dd0
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
loki/templates/backend/statefulset-backend.yaml
*** /home/runner/work/loki/loki/output/base/ingress-values/loki/templates/backend/statefulset-backend.yaml	2024-11-08 17:22:24.662280558 +0000
--- /home/runner/work/loki/loki/output/pr/ingress-values/loki/templates/backend/statefulset-backend.yaml	2024-11-08 17:22:27.002293265 +0000
***************
*** 33,39 ****
 template:
 metadata:
 annotations:
! checksum/config: 540324ec0074bd0542be3e9a36892034c213d8576418c25ef5dd4443df6b354f
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
--- 33,39 ----
 template:
 metadata:
 annotations:
! checksum/config: 0f9b18140fe2d1a072eacec48cbcc71c660b410bac12421fd6931ae4c1495dd0
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name

Removed Files

No removed files

Scenario: legacy-monitoring-values (Added: 0, Modified: 4, Removed: 0)

Summary:

  • Added: 0

  • Modified: 4

  • Removed: 0

Added Files

No added files

Modified Files

loki/templates/read/deployment-read.yaml
*** /home/runner/work/loki/loki/output/base/legacy-monitoring-values/loki/templates/read/deployment-read.yaml	2024-11-08 17:22:24.762281101 +0000
--- /home/runner/work/loki/loki/output/pr/legacy-monitoring-values/loki/templates/read/deployment-read.yaml	2024-11-08 17:22:27.102293808 +0000
***************
*** 28,34 ****
 template:
 metadata:
 annotations:
! checksum/config: 540324ec0074bd0542be3e9a36892034c213d8576418c25ef5dd4443df6b354f
 labels:
 app.kubernetes.io/part-of: memberlist
 app.kubernetes.io/name: loki
--- 28,34 ----
 template:
 metadata:
 annotations:
! checksum/config: 0f9b18140fe2d1a072eacec48cbcc71c660b410bac12421fd6931ae4c1495dd0
 labels:
 app.kubernetes.io/part-of: memberlist
 app.kubernetes.io/name: loki
loki/templates/config.yaml
*** /home/runner/work/loki/loki/output/base/legacy-monitoring-values/loki/templates/config.yaml	2024-11-08 17:22:24.762281101 +0000
--- /home/runner/work/loki/loki/output/pr/legacy-monitoring-values/loki/templates/config.yaml	2024-11-08 17:22:27.102293808 +0000
***************
*** 14,20 ****
 data:
 config.yaml: |
 
! auth_enabled: true
 bloom_build:
 builder:
 planner_address: loki-backend-headless.default.svc.cluster.local:9095
--- 14,20 ----
 data:
 config.yaml: |
 
! map[admin:admin chunks:chunks ruler:ruler]auth_enabled: true
 bloom_build:
 builder:
 planner_address: loki-backend-headless.default.svc.cluster.local:9095
loki/templates/write/statefulset-write.yaml
*** /home/runner/work/loki/loki/output/base/legacy-monitoring-values/loki/templates/write/statefulset-write.yaml	2024-11-08 17:22:24.762281101 +0000
--- /home/runner/work/loki/loki/output/pr/legacy-monitoring-values/loki/templates/write/statefulset-write.yaml	2024-11-08 17:22:27.102293808 +0000
***************
*** 29,35 ****
 template:
 metadata:
 annotations:
! checksum/config: 540324ec0074bd0542be3e9a36892034c213d8576418c25ef5dd4443df6b354f
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
--- 29,35 ----
 template:
 metadata:
 annotations:
! checksum/config: 0f9b18140fe2d1a072eacec48cbcc71c660b410bac12421fd6931ae4c1495dd0
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
loki/templates/backend/statefulset-backend.yaml
*** /home/runner/work/loki/loki/output/base/legacy-monitoring-values/loki/templates/backend/statefulset-backend.yaml	2024-11-08 17:22:24.762281101 +0000
--- /home/runner/work/loki/loki/output/pr/legacy-monitoring-values/loki/templates/backend/statefulset-backend.yaml	2024-11-08 17:22:27.102293808 +0000
***************
*** 33,39 ****
 template:
 metadata:
 annotations:
! checksum/config: 540324ec0074bd0542be3e9a36892034c213d8576418c25ef5dd4443df6b354f
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
--- 33,39 ----
 template:
 metadata:
 annotations:
! checksum/config: 0f9b18140fe2d1a072eacec48cbcc71c660b410bac12421fd6931ae4c1495dd0
 labels:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name

Removed Files

No removed files

Scenario: simple-scalable-aws-kube-irsa-values (Added: 0, Modified: 6, Removed: 0)

Summary:

  • Added: 0

  • Modified: 6

  • Removed: 0

Added Files

No added files

Modified Files

loki/templates/read/deployment-read.yaml
*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/read/deployment-read.yaml	2024-11-08 17:22:24.870281688 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/read/deployment-read.yaml	2024-11-08 17:22:27.214294416 +0000
***************
*** 28,34 ****
 template:
 metadata:
 annotations:
! checksum/config: 4a89247c5f729aa7f742986de6f9a88a88f538f66b6b811414428c60920e5934
 labels:
 app.kubernetes.io/part-of: memberlist
 app.kubernetes.io/name: enterprise-logs
--- 28,34 ----
 template:
 metadata:
 annotations:
! checksum/config: 4cc74adde78d167875ed84f6f542d31f4baf309ca80fc133eedcffe357d4ea5a
 labels:
 app.kubernetes.io/part-of: memberlist
 app.kubernetes.io/name: enterprise-logs
loki/templates/config.yaml
*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/config.yaml	2024-11-08 17:22:24.870281688 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/config.yaml	2024-11-08 17:22:27.214294416 +0000
***************
*** 14,20 ****
 data:
 config.yaml: |
 
! admin_client:
 storage:
 backend: s3
 s3:
--- 14,20 ----
 data:
 config.yaml: |
 
! map[admin:aws-s3-admin-bucket chunks:aws-s3-chunks-bucket ruler:aws-s3-ruler-bucket]admin_client:
 storage:
 backend: s3
 s3:
loki/templates/write/statefulset-write.yaml
*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/write/statefulset-write.yaml	2024-11-08 17:22:24.870281688 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/write/statefulset-write.yaml	2024-11-08 17:22:27.214294416 +0000
***************
*** 29,35 ****
 template:
 metadata:
 annotations:
! checksum/config: 4a89247c5f729aa7f742986de6f9a88a88f538f66b6b811414428c60920e5934
 labels:
 app.kubernetes.io/name: enterprise-logs
 app.kubernetes.io/instance: loki-test-chart-name
--- 29,35 ----
 template:
 metadata:
 annotations:
! checksum/config: 4cc74adde78d167875ed84f6f542d31f4baf309ca80fc133eedcffe357d4ea5a
 labels:
 app.kubernetes.io/name: enterprise-logs
 app.kubernetes.io/instance: loki-test-chart-name
loki/templates/gateway/deployment-gateway-enterprise.yaml
*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/gateway/deployment-gateway-enterprise.yaml	2024-11-08 17:22:24.870281688 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/gateway/deployment-gateway-enterprise.yaml	2024-11-08 17:22:27.214294416 +0000
***************
*** 28,34 ****
 app.kubernetes.io/instance: loki-test-chart-name
 app.kubernetes.io/component: gateway
 annotations:
! checksum/config: 4a89247c5f729aa7f742986de6f9a88a88f538f66b6b811414428c60920e5934
 spec:
 serviceAccountName: enterprise-logs
 securityContext:
--- 28,34 ----
 app.kubernetes.io/instance: loki-test-chart-name
 app.kubernetes.io/component: gateway
 annotations:
! checksum/config: 4cc74adde78d167875ed84f6f542d31f4baf309ca80fc133eedcffe357d4ea5a
 spec:
 serviceAccountName: enterprise-logs
 securityContext:
loki/templates/admin-api/deployment-admin-api.yaml
*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/admin-api/deployment-admin-api.yaml	2024-11-08 17:22:24.870281688 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/admin-api/deployment-admin-api.yaml	2024-11-08 17:22:27.214294416 +0000
***************
*** 33,39 ****
 target: admin-api
 app.kubernetes.io/part-of: memberlist
 annotations:
! checksum/config: 4a89247c5f729aa7f742986de6f9a88a88f538f66b6b811414428c60920e5934
 spec:
 serviceAccountName: enterprise-logs
 securityContext:
--- 33,39 ----
 target: admin-api
 app.kubernetes.io/part-of: memberlist
 annotations:
! checksum/config: 4cc74adde78d167875ed84f6f542d31f4baf309ca80fc133eedcffe357d4ea5a
 spec:
 serviceAccountName: enterprise-logs
 securityContext:
loki/templates/backend/statefulset-backend.yaml
*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/backend/statefulset-backend.yaml	2024-11-08 17:22:24.870281688 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/backend/statefulset-backend.yaml	2024-11-08 17:22:27.214294416 +0000
***************
*** 33,39 ****
 template:
 metadata:
 annotations:
! checksum/config: 4a89247c5f729aa7f742986de6f9a88a88f538f66b6b811414428c60920e5934
 labels:
 app.kubernetes.io/name: enterprise-logs
 app.kubernetes.io/instance: loki-test-chart-name
--- 33,39 ----
 template:
 metadata:
 annotations:
! checksum/config: 4cc74adde78d167875ed84f6f542d31f4baf309ca80fc133eedcffe357d4ea5a
 labels:
 app.kubernetes.io/name: enterprise-logs
 app.kubernetes.io/instance: loki-test-chart-name

Removed Files

No removed files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants