-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: helm: Add validation that checks for empty bucket configuration #14843
Open
DylanGuedes
wants to merge
5
commits into
main
Choose a base branch
from
fix-helmchart
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Kubernetes Manifest Diff SummaryScenario: default-single-binary-values (Added: 0, Modified: 11, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/querier/deployment-querier.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/querier/deployment-querier.yaml 2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/querier/deployment-querier.yaml 2024-11-08 17:22:26.806292200 +0000
***************
*** 28,34 ****
template:
metadata:
annotations:
! checksum/config: 8afd86b031d6b47b96a59259a9e3393a95d5b321e5b9f5b492a2880b96042d52
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 28,34 ----
template:
metadata:
annotations:
! checksum/config: 1586195cf9cfc78f6a555943e6e87dc841b20b40ed9aaa740cf2353be32247ac
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/query-frontend/deployment-query-frontend.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/query-frontend/deployment-query-frontend.yaml 2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/query-frontend/deployment-query-frontend.yaml 2024-11-08 17:22:26.806292200 +0000
***************
*** 27,33 ****
template:
metadata:
annotations:
! checksum/config: 8afd86b031d6b47b96a59259a9e3393a95d5b321e5b9f5b492a2880b96042d52
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 27,33 ----
template:
metadata:
annotations:
! checksum/config: 1586195cf9cfc78f6a555943e6e87dc841b20b40ed9aaa740cf2353be32247ac
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/compactor/statefulset-compactor.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/compactor/statefulset-compactor.yaml 2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/compactor/statefulset-compactor.yaml 2024-11-08 17:22:26.810292222 +0000
***************
*** 29,35 ****
template:
metadata:
annotations:
! checksum/config: 8afd86b031d6b47b96a59259a9e3393a95d5b321e5b9f5b492a2880b96042d52
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 29,35 ----
template:
metadata:
annotations:
! checksum/config: 1586195cf9cfc78f6a555943e6e87dc841b20b40ed9aaa740cf2353be32247ac
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/config.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/config.yaml 2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/config.yaml 2024-11-08 17:22:26.806292200 +0000
***************
*** 14,20 ****
data:
config.yaml: |
! auth_enabled: true
bloom_build:
builder:
planner_address: loki-test-chart-name-bloom-planner-headless.default.svc.cluster.local:9095
--- 14,20 ----
data:
config.yaml: |
! map[chunks:chunks ruler:ruler]auth_enabled: true
bloom_build:
builder:
planner_address: loki-test-chart-name-bloom-planner-headless.default.svc.cluster.local:9095 loki/templates/query-scheduler/deployment-query-scheduler.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/query-scheduler/deployment-query-scheduler.yaml 2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/query-scheduler/deployment-query-scheduler.yaml 2024-11-08 17:22:26.806292200 +0000
***************
*** 27,33 ****
template:
metadata:
annotations:
! checksum/config: 8afd86b031d6b47b96a59259a9e3393a95d5b321e5b9f5b492a2880b96042d52
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 27,33 ----
template:
metadata:
annotations:
! checksum/config: 1586195cf9cfc78f6a555943e6e87dc841b20b40ed9aaa740cf2353be32247ac
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/ruler/statefulset-ruler.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/ruler/statefulset-ruler.yaml 2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/ruler/statefulset-ruler.yaml 2024-11-08 17:22:26.810292222 +0000
***************
*** 24,30 ****
template:
metadata:
annotations:
! checksum/config: 8afd86b031d6b47b96a59259a9e3393a95d5b321e5b9f5b492a2880b96042d52
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 24,30 ----
template:
metadata:
annotations:
! checksum/config: 1586195cf9cfc78f6a555943e6e87dc841b20b40ed9aaa740cf2353be32247ac
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/index-gateway/statefulset-index-gateway.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/index-gateway/statefulset-index-gateway.yaml 2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/index-gateway/statefulset-index-gateway.yaml 2024-11-08 17:22:26.810292222 +0000
***************
*** 25,31 ****
template:
metadata:
annotations:
! checksum/config: 8afd86b031d6b47b96a59259a9e3393a95d5b321e5b9f5b492a2880b96042d52
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 25,31 ----
template:
metadata:
annotations:
! checksum/config: 1586195cf9cfc78f6a555943e6e87dc841b20b40ed9aaa740cf2353be32247ac
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/ingester/statefulset-ingester-zone-c.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-c.yaml 2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-c.yaml 2024-11-08 17:22:26.810292222 +0000
***************
*** 34,40 ****
template:
metadata:
annotations:
! checksum/config: 8afd86b031d6b47b96a59259a9e3393a95d5b321e5b9f5b492a2880b96042d52
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 34,40 ----
template:
metadata:
annotations:
! checksum/config: 1586195cf9cfc78f6a555943e6e87dc841b20b40ed9aaa740cf2353be32247ac
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/ingester/statefulset-ingester-zone-b.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-b.yaml 2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-b.yaml 2024-11-08 17:22:26.810292222 +0000
***************
*** 34,40 ****
template:
metadata:
annotations:
! checksum/config: 8afd86b031d6b47b96a59259a9e3393a95d5b321e5b9f5b492a2880b96042d52
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 34,40 ----
template:
metadata:
annotations:
! checksum/config: 1586195cf9cfc78f6a555943e6e87dc841b20b40ed9aaa740cf2353be32247ac
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/ingester/statefulset-ingester-zone-a.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-a.yaml 2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-a.yaml 2024-11-08 17:22:26.810292222 +0000
***************
*** 34,40 ****
template:
metadata:
annotations:
! checksum/config: 8afd86b031d6b47b96a59259a9e3393a95d5b321e5b9f5b492a2880b96042d52
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 34,40 ----
template:
metadata:
annotations:
! checksum/config: 1586195cf9cfc78f6a555943e6e87dc841b20b40ed9aaa740cf2353be32247ac
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/distributor/deployment-distributor.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/distributor/deployment-distributor.yaml 2024-11-08 17:22:24.470279516 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/distributor/deployment-distributor.yaml 2024-11-08 17:22:26.806292200 +0000
***************
*** 28,34 ****
template:
metadata:
annotations:
! checksum/config: 8afd86b031d6b47b96a59259a9e3393a95d5b321e5b9f5b492a2880b96042d52
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 28,34 ----
template:
metadata:
annotations:
! checksum/config: 1586195cf9cfc78f6a555943e6e87dc841b20b40ed9aaa740cf2353be32247ac
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name Removed FilesNo removed files Scenario: default-values (Added: 0, Modified: 4, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/read/deployment-read.yaml*** /home/runner/work/loki/loki/output/base/default-values/loki/templates/read/deployment-read.yaml 2024-11-08 17:22:24.566280037 +0000
--- /home/runner/work/loki/loki/output/pr/default-values/loki/templates/read/deployment-read.yaml 2024-11-08 17:22:26.902292722 +0000
***************
*** 28,34 ****
template:
metadata:
annotations:
! checksum/config: 540324ec0074bd0542be3e9a36892034c213d8576418c25ef5dd4443df6b354f
labels:
app.kubernetes.io/part-of: memberlist
app.kubernetes.io/name: loki
--- 28,34 ----
template:
metadata:
annotations:
! checksum/config: 0f9b18140fe2d1a072eacec48cbcc71c660b410bac12421fd6931ae4c1495dd0
labels:
app.kubernetes.io/part-of: memberlist
app.kubernetes.io/name: loki loki/templates/config.yaml*** /home/runner/work/loki/loki/output/base/default-values/loki/templates/config.yaml 2024-11-08 17:22:24.566280037 +0000
--- /home/runner/work/loki/loki/output/pr/default-values/loki/templates/config.yaml 2024-11-08 17:22:26.902292722 +0000
***************
*** 14,20 ****
data:
config.yaml: |
! auth_enabled: true
bloom_build:
builder:
planner_address: loki-backend-headless.default.svc.cluster.local:9095
--- 14,20 ----
data:
config.yaml: |
! map[admin:admin chunks:chunks ruler:ruler]auth_enabled: true
bloom_build:
builder:
planner_address: loki-backend-headless.default.svc.cluster.local:9095 loki/templates/write/statefulset-write.yaml*** /home/runner/work/loki/loki/output/base/default-values/loki/templates/write/statefulset-write.yaml 2024-11-08 17:22:24.566280037 +0000
--- /home/runner/work/loki/loki/output/pr/default-values/loki/templates/write/statefulset-write.yaml 2024-11-08 17:22:26.902292722 +0000
***************
*** 29,35 ****
template:
metadata:
annotations:
! checksum/config: 540324ec0074bd0542be3e9a36892034c213d8576418c25ef5dd4443df6b354f
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 29,35 ----
template:
metadata:
annotations:
! checksum/config: 0f9b18140fe2d1a072eacec48cbcc71c660b410bac12421fd6931ae4c1495dd0
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/backend/statefulset-backend.yaml*** /home/runner/work/loki/loki/output/base/default-values/loki/templates/backend/statefulset-backend.yaml 2024-11-08 17:22:24.566280037 +0000
--- /home/runner/work/loki/loki/output/pr/default-values/loki/templates/backend/statefulset-backend.yaml 2024-11-08 17:22:26.902292722 +0000
***************
*** 33,39 ****
template:
metadata:
annotations:
! checksum/config: 540324ec0074bd0542be3e9a36892034c213d8576418c25ef5dd4443df6b354f
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 33,39 ----
template:
metadata:
annotations:
! checksum/config: 0f9b18140fe2d1a072eacec48cbcc71c660b410bac12421fd6931ae4c1495dd0
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name Removed FilesNo removed files Scenario: ingress-values (Added: 0, Modified: 4, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/read/deployment-read.yaml*** /home/runner/work/loki/loki/output/base/ingress-values/loki/templates/read/deployment-read.yaml 2024-11-08 17:22:24.662280558 +0000
--- /home/runner/work/loki/loki/output/pr/ingress-values/loki/templates/read/deployment-read.yaml 2024-11-08 17:22:27.002293265 +0000
***************
*** 28,34 ****
template:
metadata:
annotations:
! checksum/config: 540324ec0074bd0542be3e9a36892034c213d8576418c25ef5dd4443df6b354f
labels:
app.kubernetes.io/part-of: memberlist
app.kubernetes.io/name: loki
--- 28,34 ----
template:
metadata:
annotations:
! checksum/config: 0f9b18140fe2d1a072eacec48cbcc71c660b410bac12421fd6931ae4c1495dd0
labels:
app.kubernetes.io/part-of: memberlist
app.kubernetes.io/name: loki loki/templates/config.yaml*** /home/runner/work/loki/loki/output/base/ingress-values/loki/templates/config.yaml 2024-11-08 17:22:24.658280537 +0000
--- /home/runner/work/loki/loki/output/pr/ingress-values/loki/templates/config.yaml 2024-11-08 17:22:26.998293243 +0000
***************
*** 14,20 ****
data:
config.yaml: |
! auth_enabled: true
bloom_build:
builder:
planner_address: loki-backend-headless.default.svc.cluster.local:9095
--- 14,20 ----
data:
config.yaml: |
! map[admin:admin chunks:chunks ruler:ruler]auth_enabled: true
bloom_build:
builder:
planner_address: loki-backend-headless.default.svc.cluster.local:9095 loki/templates/write/statefulset-write.yaml*** /home/runner/work/loki/loki/output/base/ingress-values/loki/templates/write/statefulset-write.yaml 2024-11-08 17:22:24.662280558 +0000
--- /home/runner/work/loki/loki/output/pr/ingress-values/loki/templates/write/statefulset-write.yaml 2024-11-08 17:22:27.002293265 +0000
***************
*** 29,35 ****
template:
metadata:
annotations:
! checksum/config: 540324ec0074bd0542be3e9a36892034c213d8576418c25ef5dd4443df6b354f
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 29,35 ----
template:
metadata:
annotations:
! checksum/config: 0f9b18140fe2d1a072eacec48cbcc71c660b410bac12421fd6931ae4c1495dd0
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/backend/statefulset-backend.yaml*** /home/runner/work/loki/loki/output/base/ingress-values/loki/templates/backend/statefulset-backend.yaml 2024-11-08 17:22:24.662280558 +0000
--- /home/runner/work/loki/loki/output/pr/ingress-values/loki/templates/backend/statefulset-backend.yaml 2024-11-08 17:22:27.002293265 +0000
***************
*** 33,39 ****
template:
metadata:
annotations:
! checksum/config: 540324ec0074bd0542be3e9a36892034c213d8576418c25ef5dd4443df6b354f
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 33,39 ----
template:
metadata:
annotations:
! checksum/config: 0f9b18140fe2d1a072eacec48cbcc71c660b410bac12421fd6931ae4c1495dd0
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name Removed FilesNo removed files Scenario: legacy-monitoring-values (Added: 0, Modified: 4, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/read/deployment-read.yaml*** /home/runner/work/loki/loki/output/base/legacy-monitoring-values/loki/templates/read/deployment-read.yaml 2024-11-08 17:22:24.762281101 +0000
--- /home/runner/work/loki/loki/output/pr/legacy-monitoring-values/loki/templates/read/deployment-read.yaml 2024-11-08 17:22:27.102293808 +0000
***************
*** 28,34 ****
template:
metadata:
annotations:
! checksum/config: 540324ec0074bd0542be3e9a36892034c213d8576418c25ef5dd4443df6b354f
labels:
app.kubernetes.io/part-of: memberlist
app.kubernetes.io/name: loki
--- 28,34 ----
template:
metadata:
annotations:
! checksum/config: 0f9b18140fe2d1a072eacec48cbcc71c660b410bac12421fd6931ae4c1495dd0
labels:
app.kubernetes.io/part-of: memberlist
app.kubernetes.io/name: loki loki/templates/config.yaml*** /home/runner/work/loki/loki/output/base/legacy-monitoring-values/loki/templates/config.yaml 2024-11-08 17:22:24.762281101 +0000
--- /home/runner/work/loki/loki/output/pr/legacy-monitoring-values/loki/templates/config.yaml 2024-11-08 17:22:27.102293808 +0000
***************
*** 14,20 ****
data:
config.yaml: |
! auth_enabled: true
bloom_build:
builder:
planner_address: loki-backend-headless.default.svc.cluster.local:9095
--- 14,20 ----
data:
config.yaml: |
! map[admin:admin chunks:chunks ruler:ruler]auth_enabled: true
bloom_build:
builder:
planner_address: loki-backend-headless.default.svc.cluster.local:9095 loki/templates/write/statefulset-write.yaml*** /home/runner/work/loki/loki/output/base/legacy-monitoring-values/loki/templates/write/statefulset-write.yaml 2024-11-08 17:22:24.762281101 +0000
--- /home/runner/work/loki/loki/output/pr/legacy-monitoring-values/loki/templates/write/statefulset-write.yaml 2024-11-08 17:22:27.102293808 +0000
***************
*** 29,35 ****
template:
metadata:
annotations:
! checksum/config: 540324ec0074bd0542be3e9a36892034c213d8576418c25ef5dd4443df6b354f
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 29,35 ----
template:
metadata:
annotations:
! checksum/config: 0f9b18140fe2d1a072eacec48cbcc71c660b410bac12421fd6931ae4c1495dd0
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/backend/statefulset-backend.yaml*** /home/runner/work/loki/loki/output/base/legacy-monitoring-values/loki/templates/backend/statefulset-backend.yaml 2024-11-08 17:22:24.762281101 +0000
--- /home/runner/work/loki/loki/output/pr/legacy-monitoring-values/loki/templates/backend/statefulset-backend.yaml 2024-11-08 17:22:27.102293808 +0000
***************
*** 33,39 ****
template:
metadata:
annotations:
! checksum/config: 540324ec0074bd0542be3e9a36892034c213d8576418c25ef5dd4443df6b354f
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 33,39 ----
template:
metadata:
annotations:
! checksum/config: 0f9b18140fe2d1a072eacec48cbcc71c660b410bac12421fd6931ae4c1495dd0
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name Removed FilesNo removed files Scenario: simple-scalable-aws-kube-irsa-values (Added: 0, Modified: 6, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/read/deployment-read.yaml*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/read/deployment-read.yaml 2024-11-08 17:22:24.870281688 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/read/deployment-read.yaml 2024-11-08 17:22:27.214294416 +0000
***************
*** 28,34 ****
template:
metadata:
annotations:
! checksum/config: 4a89247c5f729aa7f742986de6f9a88a88f538f66b6b811414428c60920e5934
labels:
app.kubernetes.io/part-of: memberlist
app.kubernetes.io/name: enterprise-logs
--- 28,34 ----
template:
metadata:
annotations:
! checksum/config: 4cc74adde78d167875ed84f6f542d31f4baf309ca80fc133eedcffe357d4ea5a
labels:
app.kubernetes.io/part-of: memberlist
app.kubernetes.io/name: enterprise-logs loki/templates/config.yaml*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/config.yaml 2024-11-08 17:22:24.870281688 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/config.yaml 2024-11-08 17:22:27.214294416 +0000
***************
*** 14,20 ****
data:
config.yaml: |
! admin_client:
storage:
backend: s3
s3:
--- 14,20 ----
data:
config.yaml: |
! map[admin:aws-s3-admin-bucket chunks:aws-s3-chunks-bucket ruler:aws-s3-ruler-bucket]admin_client:
storage:
backend: s3
s3: loki/templates/write/statefulset-write.yaml*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/write/statefulset-write.yaml 2024-11-08 17:22:24.870281688 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/write/statefulset-write.yaml 2024-11-08 17:22:27.214294416 +0000
***************
*** 29,35 ****
template:
metadata:
annotations:
! checksum/config: 4a89247c5f729aa7f742986de6f9a88a88f538f66b6b811414428c60920e5934
labels:
app.kubernetes.io/name: enterprise-logs
app.kubernetes.io/instance: loki-test-chart-name
--- 29,35 ----
template:
metadata:
annotations:
! checksum/config: 4cc74adde78d167875ed84f6f542d31f4baf309ca80fc133eedcffe357d4ea5a
labels:
app.kubernetes.io/name: enterprise-logs
app.kubernetes.io/instance: loki-test-chart-name loki/templates/gateway/deployment-gateway-enterprise.yaml*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/gateway/deployment-gateway-enterprise.yaml 2024-11-08 17:22:24.870281688 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/gateway/deployment-gateway-enterprise.yaml 2024-11-08 17:22:27.214294416 +0000
***************
*** 28,34 ****
app.kubernetes.io/instance: loki-test-chart-name
app.kubernetes.io/component: gateway
annotations:
! checksum/config: 4a89247c5f729aa7f742986de6f9a88a88f538f66b6b811414428c60920e5934
spec:
serviceAccountName: enterprise-logs
securityContext:
--- 28,34 ----
app.kubernetes.io/instance: loki-test-chart-name
app.kubernetes.io/component: gateway
annotations:
! checksum/config: 4cc74adde78d167875ed84f6f542d31f4baf309ca80fc133eedcffe357d4ea5a
spec:
serviceAccountName: enterprise-logs
securityContext: loki/templates/admin-api/deployment-admin-api.yaml*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/admin-api/deployment-admin-api.yaml 2024-11-08 17:22:24.870281688 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/admin-api/deployment-admin-api.yaml 2024-11-08 17:22:27.214294416 +0000
***************
*** 33,39 ****
target: admin-api
app.kubernetes.io/part-of: memberlist
annotations:
! checksum/config: 4a89247c5f729aa7f742986de6f9a88a88f538f66b6b811414428c60920e5934
spec:
serviceAccountName: enterprise-logs
securityContext:
--- 33,39 ----
target: admin-api
app.kubernetes.io/part-of: memberlist
annotations:
! checksum/config: 4cc74adde78d167875ed84f6f542d31f4baf309ca80fc133eedcffe357d4ea5a
spec:
serviceAccountName: enterprise-logs
securityContext: loki/templates/backend/statefulset-backend.yaml*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/backend/statefulset-backend.yaml 2024-11-08 17:22:24.870281688 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/backend/statefulset-backend.yaml 2024-11-08 17:22:27.214294416 +0000
***************
*** 33,39 ****
template:
metadata:
annotations:
! checksum/config: 4a89247c5f729aa7f742986de6f9a88a88f538f66b6b811414428c60920e5934
labels:
app.kubernetes.io/name: enterprise-logs
app.kubernetes.io/instance: loki-test-chart-name
--- 33,39 ----
template:
metadata:
annotations:
! checksum/config: 4cc74adde78d167875ed84f6f542d31f4baf309ca80fc133eedcffe357d4ea5a
labels:
app.kubernetes.io/name: enterprise-logs
app.kubernetes.io/instance: loki-test-chart-name Removed FilesNo removed files |
trevorwhitney
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We removed the possibility of running the chart by default without setting any bucket configuration, as this can lead to security incidents (you could end up sending your data to a bucket you don't have access to).
However, the error message isn't clear on that. This PR fixes it by throwing a more explicit error.
I'm putting it inside that
define
block because that block is being evaluated before ourtemplates/validate
code is triggered.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR