Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change pushHandler to return 200 not 204 #15801

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Change pushHandler to return 200 not 204 #15801

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f8756d
fix: Change pushHandler to return 200 not 204
sysadmin1139 Jan 16, 2025
d415006
Merge branch 'main' into fix-15761
sysadmin1139 Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/distributor/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func (d *Distributor) pushHandler(w http.ResponseWriter, r *http.Request, pushRe
"msg", "push request successful",
)
}
w.WriteHeader(http.StatusNoContent)
w.WriteHeader(http.StatusOK)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would change the response status code for both the /otlp/v1/logs and the regular /api/v1/push endpoints. We definitely don't want to change the latter.

You would need to provide the return status code as argument in the pushHandler function.

return
}

Expand Down
Loading