Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add notes on node types #15916

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

poyzannur
Copy link
Contributor

@poyzannur poyzannur commented Jan 23, 2025

What this PR does / why we need it:
This is a follow up on #15820
Adds notes for suggested node types of AWS and GCP

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@poyzannur poyzannur requested a review from a team as a code owner January 23, 2025 14:42
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jan 23, 2025
Copy link
Contributor

github-actions bot commented Jan 23, 2025

💻 Deploy preview deleted.

@poyzannur poyzannur changed the title Add notes on node types docs: Add notes on node types Jan 23, 2025
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 23, 2025
@poyzannur poyzannur merged commit d73cdd2 into main Jan 23, 2025
64 checks passed
@poyzannur poyzannur deleted the poyzan/update-node-types-on-sizing-doc branch January 23, 2025 14:55
loki-gh-app bot pushed a commit that referenced this pull request Jan 23, 2025
loki-gh-app bot pushed a commit that referenced this pull request Jan 23, 2025
loki-gh-app bot pushed a commit that referenced this pull request Jan 23, 2025
loki-gh-app bot pushed a commit that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.0.x backport release-3.1.x backport release-3.2.x backport release-3.3.x size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants