Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Fix in-cluster remote URLs when gateway and nginx are disabled #10625

Merged
merged 6 commits into from
Feb 14, 2025

Conversation

kimxogus
Copy link
Contributor

@kimxogus kimxogus commented Feb 11, 2025

What this PR does

Current mimir-distributed helm chart creates in-cluster remote urls nginx service's cluster url even when nginx is disabled.

This PR fixes this behavior. mimir.remoteWriteUrl.inCluster and mimir.remoteReadUrl.inCluster will be query-frontend and distributor's url when both gateway and nginx are disabled.

Which issue(s) this PR fixes or relates to

none

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@kimxogus kimxogus requested a review from a team as a code owner February 11, 2025 06:16
Copy link
Contributor

@narqo narqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for fixing it.

operations/helm/charts/mimir-distributed/CHANGELOG.md Outdated Show resolved Hide resolved
@narqo narqo enabled auto-merge (squash) February 14, 2025 19:38
@narqo narqo changed the title Fix in-cluster remote urls when gateway and nginx are disabled helm: Fix in-cluster remote URLs when gateway and nginx are disabled Feb 14, 2025
@narqo narqo merged commit 74c29a9 into grafana:main Feb 14, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants