helm: Fix in-cluster remote URLs when gateway and nginx are disabled #10625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Current mimir-distributed helm chart creates in-cluster remote urls nginx service's cluster url even when nginx is disabled.
mimir/operations/helm/charts/mimir-distributed/templates/_helpers.tpl
Lines 37 to 43 in 9144986
This PR fixes this behavior.
mimir.remoteWriteUrl.inCluster
andmimir.remoteReadUrl.inCluster
will be query-frontend and distributor's url when both gateway and nginx are disabled.Which issue(s) this PR fixes or relates to
none
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.