mimir-rules-action: set-output is deprecated
#4372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ `set-output` will stop working on June 1st and is currently warning
|
|
charleskorn
reviewed
Mar 5, 2023
Summary should use the multiline format: github/docs#21529
julienduchesne
force-pushed
the
julienduchesne/set-output-is-deprecated
branch
from
a5ac4fd to
f005a21
Compare
charleskorn
approved these changes
Mar 7, 2023
pracucci
reviewed
Mar 7, 2023
| SUMMARY=$(echo "${OUTPUT}" | grep Summary) | ||
| echo ::set-output name=summary::"${SUMMARY}" | ||
| echo 'summary<<ENDOFSUMMARY' >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Note to reviewers: I thought we needed the = sign after summary here, but apparently it's not required: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#multiline-strings
pracucci
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
set-outputwill stop working on June 1st and is currently warningThis was tested on our internal workflow