Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: rename scrape_native_histograms setting based on prometheus update #9856

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

tacole02
Copy link
Contributor

@tacole02 tacole02 commented Nov 9, 2024

What this PR does

This PR updates the scrape_native_histograms setting to always_scrape_native_histograms at https://grafana.com/docs/mimir/latest/send/native-histograms/. This update is based on a change in Prometheus version 3.0.

Which issue(s) this PR fixes or relates to

Fixes #9695

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@tacole02 tacole02 requested a review from a team as a code owner November 9, 2024 00:30
@tacole02 tacole02 self-assigned this Nov 9, 2024
@tacole02 tacole02 added the type/docs Improvements or additions to documentation label Nov 9, 2024
@tacole02 tacole02 requested a review from krajorama November 9, 2024 00:35
@tacole02
Copy link
Contributor Author

Hi @krajorama , please approve and merge this PR if the change looks good to you! Thanks!

Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tacole02
Copy link
Contributor Author

Thanks so much, @56quarters ! Do you mind merging this PR? I don't have merge rights for this repo.

@56quarters 56quarters merged commit 5d19981 into main Nov 15, 2024
29 checks passed
@56quarters 56quarters deleted the docs/rename_scrape_native_histograms branch November 15, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: scrape_classic_histograms renamed to always_scrape_classic_histograms in Prometheus 3.0
2 participants