Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Grafana Cloud Fleet Management #1989

Merged
merged 30 commits into from
Feb 13, 2025

Conversation

johannaojeling
Copy link
Member

Adds support for managing Grafana Cloud Fleet Management resources.

Changes:

  • Adds 2 new fields to the provider
    • fleet_management_auth
    • fleet_management_url
  • Adds 4 new fields to the Cloud stack resource and data source
    • fleet_management_name
    • fleet_management_status
    • fleet_management_url
    • fleet_management_user_id
  • Introduces a new Fleet Management Collector resource
  • Introduces a new Fleet Management Pipeline resource

@johannaojeling johannaojeling requested review from a team as code owners January 20, 2025 13:44
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

Copy link
Member

@tpaschalis tpaschalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much experience around Terraform and providers, but after scanning through these a couple of times and going through a demo, this LGTM, but I'd appreciate a review from someone with more experience. Let's make sure that we're marking resources with the correct stability labels for the future.

Nice work!

pkg/provider/configure_clients.go Show resolved Hide resolved
@johannaojeling johannaojeling force-pushed the johannaojeling/fleet-management branch 2 times, most recently from 2d57cee to 79e3e1e Compare January 29, 2025 12:04
Copy link
Member

@Duologic Duologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look at the more common parts (client, examples, stuff in pkg/), LGTM!

I didn't dig too much into the resources themselves, I think its better for the team behind fleet management to have a look at those and check if they are correct.

@johannaojeling johannaojeling force-pushed the johannaojeling/fleet-management branch from 62c865b to 70e7ab5 Compare February 12, 2025 12:45
@johannaojeling
Copy link
Member Author

Blocked by #2024 to fix the failing unit tests / docs check

@johannaojeling johannaojeling force-pushed the johannaojeling/fleet-management branch from 70e7ab5 to cfb92eb Compare February 13, 2025 08:16
@johannaojeling johannaojeling merged commit 683e6c1 into main Feb 13, 2025
26 checks passed
@johannaojeling johannaojeling deleted the johannaojeling/fleet-management branch February 13, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants