-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Grafana Cloud Fleet Management #1989
Conversation
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much experience around Terraform and providers, but after scanning through these a couple of times and going through a demo, this LGTM, but I'd appreciate a review from someone with more experience. Let's make sure that we're marking resources with the correct stability labels for the future.
Nice work!
2d57cee
to
79e3e1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look at the more common parts (client, examples, stuff in pkg/), LGTM!
I didn't dig too much into the resources themselves, I think its better for the team behind fleet management to have a look at those and check if they are correct.
62c865b
to
70e7ab5
Compare
Blocked by #2024 to fix the failing |
70e7ab5
to
cfb92eb
Compare
Adds support for managing Grafana Cloud Fleet Management resources.
Changes:
fleet_management_auth
fleet_management_url
fleet_management_name
fleet_management_status
fleet_management_url
fleet_management_user_id