Add timeout to Goto

grafana · Aug 12, 2022 · 3ea0c25 · 3ea0c25
1 parent fac54bd
commit 3ea0c25
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/tests/frame_manager_test.go b/tests/frame_manager_test.go
@@ -39,7 +39,10 @@ func TestWaitForFrameNavigationWithinDocument(t *testing.T) {
 				tb := newTestBrowser(t, withFileServer())
 				p := tb.NewPage(nil)
 
-				resp := p.Goto(tb.staticURL("/nav_in_doc.html"), nil)
+				resp := p.Goto(tb.staticURL("/nav_in_doc.html"), tb.toGojaValue(&common.FrameGotoOptions{
+					WaitUntil: common.LifecycleEventNetworkIdle,
+					Timeout:   timeout, // interpreted as ms
+				}))
 				require.NotNil(t, resp)
 
 				// Callbacks that are initiated internally by click and WaitForNavigation