Update to work with frameLifecycleEvent

common/frame_manager.go

@@ -216,23 +216,6 @@ func (m *FrameManager) frameLifecycleEvent(frameID cdp.FrameID, event LifecycleE
 	}
 }
 
-// This only tries to recalculate the lifecycle and not set the
-// `networkIdle` state to the Frame. `networkIdle` events need to be
-// handled after `frameLoadingStopped`` has been called (which
-// internally sets the `networkidle` state to the Frame). Once
-// this is done, we can safely recalculateLifecycle which should
-// emit the internal `networkidle` event.
-func (m *FrameManager) frameNetworkIdleLifecycleEvent(frameID cdp.FrameID, event LifecycleEvent) {
-	m.logger.Debugf("FrameManager:frameNetworkIdleLifecycleEvent",
-		"fmid:%d fid:%v event:%s",
-		m.ID(), frameID, lifecycleEventToString[event])
-
-	frame := m.getFrameByID(frameID)
-	if frame != nil {
-		frame.recalculateLifecycle()
-	}
-}
-
 func (m *FrameManager) frameLoadingStarted(frameID cdp.FrameID) {
 	m.logger.Debugf("FrameManager:frameLoadingStarted",
 		"fmid:%d fid:%v", m.ID(), frameID)

common/frame_session.go

@@ -722,7 +722,7 @@ func (fs *FrameSession) onPageLifecycle(event *cdppage.EventLifecycleEvent) {
 	case "DOMContentLoaded":
 		fs.manager.frameLifecycleEvent(event.FrameID, LifecycleEventDOMContentLoad)
 	case "networkIdle":
-		fs.manager.frameNetworkIdleLifecycleEvent(event.FrameID, LifecycleEventNetworkIdle)
+		fs.manager.frameLifecycleEvent(event.FrameID, LifecycleEventNetworkIdle)
 	}
 
 	eventToMetric := map[string]*k6metrics.Metric{