Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

Commit

Permalink
Remove the CI specific timeout
Browse files Browse the repository at this point in the history
We shouldn't need the CI specific timeout since the test should now
be less flaky and is asynchronous.

Resolves: #467 (comment)
  • Loading branch information
ankur22 committed Aug 11, 2022
1 parent 61b84ee commit b27f684
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions tests/frame_manager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,7 @@ func TestWaitForFrameNavigationWithinDocument(t *testing.T) {
}
t.Parallel()

var timeout time.Duration = 2000 // interpreted as ms
if os.Getenv("CI") == "true" {
// Increase the timeout on underprovisioned CI machines to minimize
// chances of intermittent failures.
timeout *= 3
}
var timeout time.Duration = 5000 // interpreted as ms

testCases := []struct {
name, selector string
Expand Down

0 comments on commit b27f684

Please sign in to comment.