Remove dispose from frame_manager

This is no longer needed since it's only just logging a debug log.
grafana · Nov 11, 2022 · c199c80 · c199c80
1 parent 641b0c6
commit c199c80
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 5 deletions.
diff --git a/common/frame_manager.go b/common/frame_manager.go
@@ -98,10 +98,6 @@ func (m *FrameManager) removeBarrier(b *Barrier) {
 	m.barriers = append(m.barriers[:index], m.barriers[index+1:]...)
 }
 
-func (m *FrameManager) dispose() {
-	m.logger.Debugf("FrameManager:dispose", "fmid:%d", m.ID())
-}
-
 func (m *FrameManager) frameAbortedNavigation(frameID cdp.FrameID, errorText, documentID string) {
 	m.logger.Debugf("FrameManager:frameAbortedNavigation",
 		"fmid:%d fid:%v err:%s docid:%s",

diff --git a/common/page.go b/common/page.go
@@ -163,7 +163,6 @@ func (p *Page) didClose() {
 func (p *Page) didCrash() {
 	p.logger.Debugf("Page:didCrash", "sid:%v", p.sessionID())
 
-	p.frameManager.dispose()
 	p.emit(EventPageCrash, p)
 }