Refactor TouchScreen.Tap to return error

browser/mapping_test.go

@@ -555,7 +555,7 @@ type keyboardAPI interface { //nolint: unused
 // mapping is not tested using this interface. We use the concrete type
 // without testing its exported methods.
 type touchscreenAPI interface { //nolint: unused
-	Tap(x float64, y float64)
+	Tap(x float64, y float64) error
 }
 
 // mouseAPI is the interface of a mouse input device.

common/touchscreen.go

@@ -2,8 +2,7 @@ package common
 
 import (
 	"context"
-
-	"github.com/grafana/xk6-browser/k6ext"
+	"fmt"
 
 	"github.com/chromedp/cdproto/cdp"
 	"github.com/chromedp/cdproto/input"
@@ -31,19 +30,22 @@ func (t *Touchscreen) tap(x float64, y float64) error {
 	action := input.DispatchTouchEvent(input.TouchStart, []*input.TouchPoint{{X: x, Y: y}}).
 		WithModifiers(input.Modifier(t.keyboard.modifiers))
 	if err := action.Do(cdp.WithExecutor(t.ctx, t.session)); err != nil {
-		return err
+		return fmt.Errorf("touch start: %w", err)
 	}
+
 	action = input.DispatchTouchEvent(input.TouchEnd, []*input.TouchPoint{}).
 		WithModifiers(input.Modifier(t.keyboard.modifiers))
 	if err := action.Do(cdp.WithExecutor(t.ctx, t.session)); err != nil {
-		return err
+		return fmt.Errorf("touch end: %w", err)
 	}
+
 	return nil
 }
 
 // Tap dispatches a tap start and tap end event.
-func (t *Touchscreen) Tap(x float64, y float64) {
+func (t *Touchscreen) Tap(x float64, y float64) error {
 	if err := t.tap(x, y); err != nil {
-		k6ext.Panic(t.ctx, "tapping: %w", err)
+		return fmt.Errorf("tapping: %w", err)
 	}
+	return nil
 }