Add remoteObjectParseError #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
force-pushed
the
add/array-parsing
branch
from
786b0b8 to
5561e9e
Compare
ankur22
force-pushed
the
add/remote-error
branch
from
f3e332c to
3bcb2e2
Compare
ankur22
force-pushed
the
add/array-parsing
branch
from
133793b to
feafa26
Compare
ankur22
dismissed stale reviews from ka3de and inancgumus
The base branch was changed.
ankur22
force-pushed
the
add/remote-error
branch
from
3bcb2e2 to
82fb803
Compare
This error can be used to encapsulate the details when a remote object can not be parsed successfully.
When the json parsing fails we should work with remoteObjectParseError so that we can hopefully identify what exactly cannot be parsed.
ankur22
force-pushed
the
add/remote-error
branch
from
82fb803 to
bda54b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a new
remoteObjectParseErrorerror type.Why?
For use when parsing of remote objects fails. It should hopefully help identify what exactly failed to parse.
Checklist
Related PR(s)/Issue(s)
Updates: #987