Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

Refactor Sobek out of screenshots and byte pointer changes #1198

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Refactor Sobek out of screenshots and byte pointer changes #1198

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a0e53f4
Refactor goja parse for elementHandle.screenshot
ankur22 Jan 29, 2024
50fee95
Refactor goja parse for page.screenshot
ankur22 Jan 29, 2024
8f43269
Refactor screenshotter to return []byte
ankur22 Jan 29, 2024
0cddf7c
Remove goja type assertion
ankur22 Jan 29, 2024
43acc02
Add skip gocognit
ankur22 Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/screenshotter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ func (s *screenshotter) screenshotElement(h *ElementHandle, opts *ElementHandleS
return buf, nil
}

//nolint:funlen,cyclop
//nolint:funlen,cyclop,gocognit
ankur22 marked this conversation as resolved.
Show resolved Hide resolved
func (s *screenshotter) screenshotPage(p *Page, opts *PageScreenshotOptions) ([]byte, error) {
format := opts.Format

Expand Down
Loading