Fix interface conversion in document #149
Conversation
The error was:
panic: interface conversion: interface {} is nil, not
*common.ElementHandle
The cause of the error was trying to assert a nil result
in Frame.document to *ElementHandle. Of course, this is
probably the surface error. There may be other causes
for it, or maybe not.
It was hard to test Frame, so I used an abstraction called
FrameExecutionContext. There are a lot of problems are
happening with execution contexts. See: #125 and #49, for
example. So, it's better to make them testable, starting
here.
Fixes #53
There was a problem hiding this comment.
LGTM, just minor suggestions.
While this fixes the panic, I'm not sure what effects it will functionally have for all callers of Frame.document(). I guess we'll find out and deal with that if/when it happens.
Have you tested how this behaves with the script in #53?
+ Move frame execution context to frame.go + Remove the unnecessary Errorf in Frame.document + Make the test robust
inancgumus
force-pushed
the
fix/53-interface-conversion-error
branch
from
7b0b22a to
fd30521
Compare
Thanks 🙏
Sadly, yes, we'll find that out as we improve the tests.
Sure thing. |
It behaves like without the error 😄 More like other unsolvable errors we've seen so far. |
The error was:
panic: interface conversion: interface {} is nil, not *common.ElementHandleThe cause of the error was trying to assert a nil result in
Frame.documentto*ElementHandle. Of course, this is probably the surface error. There may be other causes for it, or maybe not.It was hard to test
Frame, so I used an abstraction calledFrameExecutionContext. There are a lot of problems are happening with execution contexts. See: #125 and #49, for example. So, it's better to make them testable, starting here.Fixes #53