Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

Removes the forgotten Geolocation.Parse #1521

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Removes the forgotten Geolocation.Parse #1521

merged 1 commit into from
Nov 7, 2024

Conversation

inancgumus
Copy link
Member

What?

Removes the forgotten Geolocation.Parse.

Why?

Not used anymore.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

@inancgumus inancgumus self-assigned this Nov 6, 2024
@inancgumus inancgumus requested a review from ankur22 November 6, 2024 20:26
@inancgumus inancgumus mentioned this pull request Nov 6, 2024
Closed
ankur22
ankur22 previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@inancgumus inancgumus requested a review from a team as a code owner November 7, 2024 14:43
@inancgumus inancgumus requested review from olegbespalov and joanlopez and removed request for a team November 7, 2024 14:43
Base automatically changed from desobekify/viewport to main November 7, 2024 14:44
@inancgumus inancgumus dismissed ankur22’s stale review November 7, 2024 14:44

The base branch was changed.

@inancgumus inancgumus force-pushed the remove/geolocation-parse branch from eadef6f to 949f9d9 Compare November 7, 2024 14:44
@inancgumus inancgumus merged commit 5100b4a into main Nov 7, 2024
9 checks passed
@inancgumus inancgumus deleted the remove/geolocation-parse branch November 7, 2024 14:44
@BrewTestBot BrewTestBot mentioned this pull request Jan 6, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ankur22 ankur22 ankur22 left review comments

@olegbespalov olegbespalov Awaiting requested review from olegbespalov olegbespalov is a code owner automatically assigned from grafana/k6-core

@joanlopez joanlopez Awaiting requested review from joanlopez joanlopez is a code owner automatically assigned from grafana/k6-core

Assignees

@inancgumus inancgumus

Labels
maintenance refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22