Fix general linter errors

[inancgumus]

This PR fixes linter errors as reported by golang-ci-lint with its default settings.

[imiric]

Thanks for this, it was starting to bug me too :)

Just some minor suggestions.

Also, let's remove the BASEREV and --new-from-rev option from the CI workflow:

xk6-browser/.github/workflows/all.yaml

Lines 54 to 56 in 4618b4a

	BASEREV=$(git merge-base HEAD origin/main)
	echo "Base revision: $BASEREV"
	golangci-lint run --timeout=3m --out-format=tab --new-from-rev "$BASEREV" ./...

[inancgumus]

Thanks for this, it was starting to bug me too :)

:)

let's remove the BASEREV and --new-from-rev option from the CI workflow:

Can you explain what will be the benefit of doing so?

[imiric]

let's remove the BASEREV and --new-from-rev option from the CI workflow:

Can you explain what will be the benefit of doing so?

That option restricts errors for only new ones introduced in a PR, but it's not needed anymore now that all linter errors are fixed. We use it in k6 since there are hundreds of old ones we haven't gotten around to fixing.

[inancgumus]

let's remove the BASEREV and --new-from-rev option from the CI workflow:

Is this change enough to do it?

- BASEREV=$(git merge-base HEAD origin/main)
- echo "Base revision: $BASEREV"
- golangci-lint run --timeout=3m --out-format=tab --new-from-rev "$BASEREV" ./...
+ golangci-lint run --timeout=3m --out-format=tab --new-from-rev ./...

[imiric]

Yeah, just drop --new-from-rev altogether.