This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
Fix type assertions and remove nolint directives for good #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
requested review from
imiric and
ankur22
and removed request for
imiric and
ankur22
ankur22
reviewed
Jun 30, 2022
ankur22
reviewed
Jun 30, 2022
This commit properly type asserts and removes nolint directives. There are new helpers to reduce code bloat and possible error messages refactoring work: + asGojaValue: returns a given value as a goja value or panics. + gojaValueToString: returns a given a value as string or panics. This commit also refactors tests to remove nolint directives. Fixes: #417
inancgumus
force-pushed
the
fix/417-panic-goja-conversion
branch
from
efd85b5 to
fc34711
Compare
ankur22
approved these changes
Jun 30, 2022
imiric
reviewed
Jul 5, 2022
imiric
approved these changes
Jul 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit properly type-asserts to remove
nolint:forcetypeassertdirectives both from the code and tests.There are new helpers to reduce code bloat and possible error messages refactoring work:
asGojaValue(v): returnsvas agojavalue or panics.gojaValueToString(v): returnsvasstringor panics.Fixes: #417
Related: grafana/k6#4496