This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
Add frame lifecycle event listener #594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
force-pushed
the
add/eventRemoval
branch
2 times, most recently
from
336a691 to
c1077f6
Compare
Adds a new goroutine to the frame manager to track a frame's lifecycle events (addition and removal). We also need to handle frame detachment. And better yet, we can put this logic in the frame, but leave the management of it to the frame manager.
inancgumus
force-pushed
the
add/eventRemoval
branch
from
c1077f6 to
130df5b
Compare
|
Since the current architecture is based on a pubsub event system, IMO, tracking the lifecycle events is a proper solution. However, the architecture and the solution in this PR are complicated, as I suggested here, it would be better to write tests first and then refactor the architecture with a simpler one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Totally experimental, probably a super dumb idea, and just for POC to concretely show what I mean here. I'm not expecting this to be merged.
We also need to handle shutting down the goroutine when a
Frameis detached, etc.We could probably do it without a goroutine, but I didn't explore that.