feat(stdlib): Add addCharFromCodePoint to Buffer module
#1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
ospencer,
phated,
peblair,
marcusroberts and
jozanza
as code owners
ospencer
reviewed
Jul 19, 2023
Co-authored-by: Oscar Spencer <[email protected]>
jozanza
approved these changes
Aug 17, 2023
peblair
approved these changes
Aug 18, 2023
phated
reviewed
Aug 20, 2023
phated
approved these changes
Aug 20, 2023
phated
changed the title
addCharFromCodePoint to bufferaddCharFromCodePoint to Buffer module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add
Buffer.addCharFromCodePointto theBuffermodule, this is used in #1133. This is very similar to doing:but it handles the correct byte count of chars.
Internally I chose to just call
addCharthis leaves less surface area for bugs to crop up, and given char is a stack type we are not giving up a ton of perf. Well once #1879 is completed.