chore(compiler): Improve unsafe equality warning #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
ospencer,
phated,
peblair,
marcusroberts and
jozanza
as code owners
ospencer
reviewed
Jul 19, 2023
|
The message phrasing seems pretty good with the module name included 😎 |
jozanza
approved these changes
Jul 22, 2023
|
Fixed those and reverted the changes |
phated
reviewed
Aug 20, 2023
phated
reviewed
Aug 20, 2023
…to spotandjake-func-wasm-unsafe
ospencer
approved these changes
Aug 20, 2023
ospencer
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small Improvement to the
FuncWasmUnsafewarning, to make it slightly more helpful.