skip associations for GRGrace

grame-cncm · Aug 2, 2023 · 54d2ad3 · 54d2ad3
1 parent 53a7837
commit 54d2ad3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/engine/graphic/GRGrace.h b/src/engine/graphic/GRGrace.h
@@ -31,7 +31,9 @@ class GRGrace : public GRARCompositeNotationElement,
 		virtual 	~GRGrace() {}
 
 		virtual void tellPosition( GObject * caller,const NVPoint & inPos );
-//		virtual void addAssociation( GRNotationElement * p );
+		// DF-02-08-2023 don't add associations to grace (useless)
+		// solves the crash bug in issue #173
+		virtual void addAssociation( GRNotationElement * p ) {}
 
 		virtual GuidoPos AddTail( GRNotationElement * el );
 };

diff --git a/src/engine/graphic/GRNotationElement.cpp b/src/engine/graphic/GRNotationElement.cpp
@@ -29,6 +29,7 @@
 #include "GRClef.h"
 #include "GRKey.h"
 #include "GRMeter.h"
+#include "GRGrace.h"
 
 // - Guido AR
 #include "ARMusicalObject.h"
@@ -372,6 +373,11 @@ NVRect GRNotationElement::getAssociatedBoundingBox() const
 // -------------------------------------------------------------------------
 void GRNotationElement::addAssociation( GRNotationElement * p )
 {
+	// DF 02-08-2023 don't associate a GRGrace to any element
+	// it's useless since notes are already notified of their 'grace' status
+	// solves the crash of issue #173
+	if (dynamic_cast<const GRGrace*>(p)) return;
+
 	if (mAssociated == 0)
 		mAssociated = new NEPointerList; // these elements don't belong to the list