Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTC date for the contributor acknowledgement banner #1196

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

roziscoding
Copy link
Contributor

This makes it so the thanked person is synced across the globe.
I'ts true that it might change during the day for people who are not on UTC timezones, but everyone will still be featured for 24 hours.

@roziscoding roziscoding self-assigned this Feb 14, 2025
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix

@KnorpelSenf KnorpelSenf requested a review from rojvv February 14, 2025 10:54
@KnorpelSenf KnorpelSenf added not translatable Translator intervention is not required. chore Modifies or is related to tooling, configuration, or setup. labels Feb 14, 2025
Copy link

@github-actions github-actions bot temporarily deployed to pull request February 14, 2025 10:56 Inactive
@rojvv rojvv changed the title update thank you component to use UTC date Use UTC date for the contributor acknowledgement banner Feb 17, 2025
@rojvv rojvv added this pull request to the merge queue Feb 17, 2025
Merged via the queue into main with commit a1fffc1 Feb 17, 2025
8 of 12 checks passed
@rojvv rojvv deleted the global-thank-you branch February 17, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Modifies or is related to tooling, configuration, or setup. not translatable Translator intervention is not required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants