-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create SetWebhookUtil component #523
Conversation
Would you be able to defer loading everything until hydration kicks in, using a dynamic import? I'm not sure it's a good idea to bundle the component framework and grammY and everything else into the static site, this will add a few hundred kB to the build. The component is usually at the very bottom of the page, so in 99 % of page visits, we have a few minutes to download the extra weight and render the component. Yes, this will mean that the component doesn't load if JS is disabled, but this actually makes a lot of sense anyway. |
This does not target bullet points 2 and 5 from #517 yet, but is generally ready for review. I'll cover those points later this week. Translation files:
Localized Pages:
|
All features are now implemented. |
It looks like it OOMs? |
I can take a closer look at a later point |
Yeah, in github actions it fails due to OOM, but locally the error is different. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to finally see this unblocked 🤓
Ping me when I should review
Closing this in favor of #633 |
Preview:
Closes #517