Zkcrypto lab1 #245
Merged
Zkcrypto lab1 #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'lynxcs-feat/lab1' into integration
Feat/arkworks wasm release
# Conflicts: # .github/workflows/zkcrypto-benchmarks.yml # .github/workflows/zkcrypto-tests.yml # Cargo.lock
lynxcs
reviewed
Nov 3, 2023
.github/workflows/backend-tests.yml
Outdated
Comment on lines
26
to
33
| - backend: blst | ||
| support_wasm: true | ||
| support_ckzg: true | ||
| # Override all-features flag for blst, due to incompatibility between portable & force-adx | ||
| clippy-flag: --features=default,std,rand,parallel | ||
| - backend: arkworks | ||
| support_wasm: true | ||
| support_ckzg: true |
There was a problem hiding this comment.
add:
- backend: zkcrypto
support_wasm: true (if project compiles on wasm target)
support_ckzg: true (if c-kzg bindings work)
EDIT: And add similar thing to backend-benchmarks.yml
lynxcs
reviewed
Nov 3, 2023
.github/workflows/release.yml
Outdated
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| backend: [blst, arkworks] |
There was a problem hiding this comment.
add zkcrypto into backend matrix so that releases contain zkcrypto zip files
… open file".to_string())?;
| ^^^^ use of undeclared type `File`
|
help: consider importing this struct
Comment on lines
+102
to
+108
| # 3.3. rust-kzg with zkcrypto backend (sequential) | ||
| print_msg "rust-kzg with zkcrypto backend (sequential)" ../"$paste_file" | ||
| taskset --cpu-list "${taskset_cpu_list[$i]}" cargo bench --manifest-path zkcrypto/Cargo.toml >> ../"$paste_file" | ||
|
|
||
| # 3.4. rust-kzg with arkworks backend (parallel) | ||
| print_msg "rust-kzg with arkworks backend (parallel)" ../"$paste_file" | ||
| taskset --cpu-list "${taskset_cpu_list[$i]}" cargo bench --manifest-path arkworks/Cargo.toml --features parallel >> ../"$paste_file" | ||
| # 3.4. rust-kzg with zkcrypto backend (parallel) | ||
| print_msg "rust-kzg with zkcrypto backend (parallel)" ../"$paste_file" | ||
| taskset --cpu-list "${taskset_cpu_list[$i]}" cargo bench --manifest-path zkcrypto/Cargo.toml --features parallel >> ../"$paste_file" |
There was a problem hiding this comment.
Is it correct? I see that benchmarks for zkcrypto are executed below.
| version = "0.12" | ||
| default-features = false | ||
| kzg = { path = "../kzg", default-features = false } | ||
| bls12_381 = { path = "../zkcrypto/bls12_381" } |
There was a problem hiding this comment.
It wasn't possible to avoid copying blst12_381 crate?
There was a problem hiding this comment.
The problem I ran into that Scalar doesn't have a public constructor that would purely create a Scalar from [u64; 4], so I can't create custom from bytes big endien. Same with to bytes - cannot access directly internal structure.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.