Optionally disable c bindings #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So the motivation to disable this by default is that potentially |
ArtiomTr
force-pushed
the
Optionally-disable-c-bindings
branch
3 times, most recently
from
1d0a945 to
884f7e6
Compare
|
Thanks, looks good! I suggest adding a note to the https://github.com/grandinetech/rust-kzg?tab=readme-ov-file#drop-in-replacement-for-c-kzg-4844 with information that it's disabled by default and needs to be enabled with a particular feature. |
ArtiomTr
force-pushed
the
Optionally-disable-c-bindings
branch
from
884f7e6 to
53de081
Compare
ArtiomTr
force-pushed
the
Optionally-disable-c-bindings
branch
from
4dff29d to
4cd7ac8
Compare
|
Done, added notice to readme that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
_rawfunctions, that accept raw bytesRelated: grandinetech/grandine#73