Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggleRenderMatrix option to hide SNPs in the Matrix #63

Merged
merged 10 commits into from
Apr 10, 2020
Merged

Conversation

6br
Copy link
Contributor

@6br 6br commented Apr 8, 2020

Issue #35
I fixed the Schematize. Further, I found CompressedViewSwitch won't work if default is true. I also fixed this.

@6br 6br requested a review from josiahseaman April 8, 2020 08:14
Copy link
Member

@josiahseaman josiahseaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't you need to also modify or switch renderAllConnectors?

@josiahseaman
Copy link
Member

image

I'm not sure the spec for this quite makes sense. The goal is likely to simplify the view. So then shouldn't we make all component the same width? Shouldn't connectors also be removed? Doesn't something like a VerticalCompression rearrangement make sense as the default here?

image
Using Vertical Compression and thinner row size shows allele frequencies.

The code works as is, but I think it needs more.

Copy link
Member

@josiahseaman josiahseaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Connectors
  • Vertical compression
  • Width compression
  • Thought about any other usability improvements (path name from cell mouseover?)

@6br
Copy link
Contributor Author

6br commented Apr 9, 2020

I'm not persuaded to remove connections, because vertical compression looks enough compressed. Removing connections lose allele frequency information. However, for evaluation, I add remove connections toggle.

Here we have four options.
(1) Vertical Compression: Thin vertical size.
(2) Width Compression: Remove all matrix and adjust the same width of Component.
(2-1) Render connectors: Remove all connection.
(2-2) Width Scaling Factor: When I remove all matrix and squeezed down to one bin for each component, I figure out that each component becomes hard to see. I think each component should be wider than one bin. That's the reason I changed the scaling factor.
I'd like to reduce the number of options.

We'd need default options. My recommendation is as follows:
(A) Default: (1)disabled (2)disabled (2-1)enabled
(B) SV w/o Phasing: (1)enabled (2)enabled (2-1)enabled (2-2)3
(C) Only SV: (1)disabled (2)enabled (2-1)enabled (2-2)3

@6br 6br marked this pull request as draft April 9, 2020 08:04
@6br 6br marked this pull request as ready for review April 9, 2020 10:25
@6br
Copy link
Contributor Author

6br commented Apr 9, 2020

Default
output (10)
SV w/o Phasing
output (11)
Only SV
output (12)

@6br
Copy link
Contributor Author

6br commented Apr 9, 2020

Connector Removed

output (13)

@6br
Copy link
Contributor Author

6br commented Apr 9, 2020

Another example:
 2020-04-09 19 43 57

@josiahseaman josiahseaman merged commit 17f291b into master Apr 10, 2020
@6br 6br deleted the i35 branch April 11, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants