-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maximum route duration + xml #246
base: master
Are you sure you want to change the base?
Conversation
Why cant we just add the VehicleRouteDurationConstraint via the ConstraintManager? |
Is your question about the conditional add of the constraint ? |
I meant why do we need to change the core at all if you can just add your DurationConstraint via the ConstraintManager. Currently, "maxDuration" can be set with "latestArrival" and "earliestDeparture". Since departure times are not variable yet, "earliestDeparture" is actually "departure". Therefore, as long as departure time is not variable, we do not necessarily need RouteDurationConstraint since it can already be modelled. If users implement smth like variable departure on their side, they can then just use your DurationConstraint then. |
If we had flexible departures then it would make sense to add new vehicle attributes such as "maxDuration" or "maxWorkingTime". |
ccbed2a
to
6e76032
Compare
I just add an updater in order to calculate the flexible departure time starting from the Actual End time as base. Calculate it using the ActivityTimeTracker will give any information on the compression of the different waiting time we could compress or not by leaving start later. |
Hi @braktar, Thanks a lot for your effort. I really appreciate it and I d love to answer and review your work immediately but often lack time. |
That's a subject which often come back on many discussion.
The idea is to have a parameter defined on the vehicle to limit the route duration. Maybe is it more logic to add it on the Driver definition ?
Ref : https://discuss.graphhopper.com/t/maximum-trip-duration-constraint/758/6