Adopted pytorch lightning DataModule instead of DataLoaders and Dataset #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: samadpls <[email protected]>
AMHermansen
reviewed
Dec 3, 2023
Signed-off-by: samadpls <[email protected]>
Signed-off-by: samadpls <[email protected]>
…tion` Signed-off-by: samadpls <[email protected]>
Signed-off-by: samadpls <[email protected]>
Signed-off-by: samadpls <[email protected]>
Signed-off-by: samadpls <[email protected]>
Signed-off-by: samadpls <[email protected]>
RasmusOrsoe
requested changes
Feb 12, 2024
There was a problem hiding this comment.
@samadpls thank you very much for this contribution! I think the PR is in great shape and that it's quite cool that you've been able to make a contribution to the backend so fast! I have left a few comments on line lengths along with some suggestions on how you can reduce them. Most of the complaints from CodeClimate is related to these lengthy lines of code, and I think it would be very quick for you to adjust them. Let me know if you have any questions!
Signed-off-by: samadpls <[email protected]>
Signed-off-by: samadpls <[email protected]>
|
@RasmusOrsoe, thank you for reviewing and giving your feedback. I have implemented the necessary adjustments to address the comment. 😋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopted PyTorch Lightning DataModule instead of managing individual DataLoaders and Dataset.
This pull request addresses and resolves issue #579