Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parsing of labels #657

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Conversation

Aske-Rosted
Copy link
Collaborator

This pull request allows for proper parsing of labels in the dataset class, such that the new "Direction" (

class Direction(Label):
) can be instantiated correctly from a dataset config by adding the following.

labels: direction: arguments: azimuth_key: azimuth zenith_key: zenith class_name: Direction

to a .yml config file.

@RasmusOrsoe
Copy link
Collaborator

@Aske-Rosted If you update this branch with the latest from main, the tests should pass. #656

Copy link
Collaborator

@RasmusOrsoe RasmusOrsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aske-Rosted thank you for adding this.

@RasmusOrsoe
Copy link
Collaborator

@Aske-Rosted please update this with latest from main before you merge

@Aske-Rosted Aske-Rosted merged commit f371526 into graphnet-team:main Mar 11, 2024
12 of 13 checks passed
@Aske-Rosted Aske-Rosted deleted the parse_labels branch March 11, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants