Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor indexer management API layer #859

Open
wants to merge 52 commits into
base: main
Choose a base branch
from
Open

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Feb 21, 2024

Summary
Rework the indexer-common GraphQL API layer to utilize GraphQL Codegen Server preset with GraphQL Yoga.

Background
When I was working on #858 I noticed that to create new resolver we update the SDL and then manually type out everything. When I was trying to write unit tests there was some bug which was causing my writes to be not written to DB. The setup is uncommon and debugging was just painful. This PR attempts to do something to reduce the pain

What does this PR change?

  1. Brings in code generation
    • Instead of typing manually we utilize code generation
    • Simplify the DB models typings
  2. A compliant GraphQL Server - With URQL setup none of the operations were being validated. I found a lot of inconsistencies within the GraphQL schema which should be caught early on.

This is first attempt to improve DX and make contributions easier. There is a lot more we can clean and improve but this already a large PR so should scope more time for follow-ups.

@saihaj saihaj marked this pull request as ready for review April 2, 2024 19:58
Copy link

gitguardian bot commented Jul 8, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
12241928 Triggered Generic High Entropy Secret 430cdeb network-configs/config.yaml View secret
12251296 Triggered Generic High Entropy Secret 430cdeb network-configs/config.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@saihaj saihaj requested a review from fordN July 9, 2024 17:49
@fordN fordN added enhancement New feature or request devex labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devex enhancement New feature or request
Projects
Status: 🚩 In Review
Development

Successfully merging this pull request may close these issues.

2 participants