-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deployment tags to replace indexer-agent
prefix in deployment names
#921
Open
datanexus-vincent
wants to merge
11
commits into
graphprotocol:main
Choose a base branch
from
datanexus-vincent:deployment-tags
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Deployment tags to replace indexer-agent
prefix in deployment names
#921
datanexus-vincent
wants to merge
11
commits into
graphprotocol:main
from
datanexus-vincent:deployment-tags
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring, string> for simplicity
…eation, reduce timer
Love this idea, @datanexus-vincent! 🙌 We'll also need some way of representing this in the actions queue so that deployments created/deployed through that flow can have tags applied too. I'll take a closer look at how to make that addition and see if we can get this in next week. |
@fordN Is there any plan to implement this yet? |
Gentle nudge from me too 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indexers need an easy way to deploy to different shards and graph-nodes. This is already possible with graph-node alone via deployment rules and deployment name regex matching, but the indexer-agent doesn't give any way to control the name that a deployment is given. With this PR, I've introduced a
tag
column for indexing rules, whose contents will replace theindexer-agent
prefix for deployment names upon first deployment.With a combination of a deployment rule like this:
and a
tag
set like this:You can now deploy VIP arbitrum subgraphs to your arbitrum VIP database directly.
Feel free to request or make changes. I'll do my best to satisfy any requirements so we can get this merged.