Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deployment tags to replace indexer-agent prefix in deployment names #921

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

datanexus-vincent
Copy link

Indexers need an easy way to deploy to different shards and graph-nodes. This is already possible with graph-node alone via deployment rules and deployment name regex matching, but the indexer-agent doesn't give any way to control the name that a deployment is given. With this PR, I've introduced a tag column for indexing rules, whose contents will replace the indexer-agent prefix for deployment names upon first deployment.

With a combination of a deployment rule like this:

[[deployment.rule]]
match = { name = "(vip|important)/.*", network = "arbitrum-one" }
shard = "arbitrum_vip"
indexers = [ "graph_node_vip_0", "graph_node_vip_1" ]

and a tag set like this:

graph indexer rules set QmHash decisionBasis offchain tag vip

You can now deploy VIP arbitrum subgraphs to your arbitrum VIP database directly.

Feel free to request or make changes. I'll do my best to satisfy any requirements so we can get this merged.

@fordN
Copy link
Contributor

fordN commented Jul 12, 2024

Love this idea, @datanexus-vincent! 🙌

We'll also need some way of representing this in the actions queue so that deployments created/deployed through that flow can have tags applied too. I'll take a closer look at how to make that addition and see if we can get this in next week.

@suntzu93
Copy link

suntzu93 commented Sep 4, 2024

@fordN Is there any plan to implement this yet?

@trader-payne
Copy link
Contributor

Gentle nudge from me too 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request indexer-agent
Projects
Status: 🚩 In Review
Development

Successfully merging this pull request may close these issues.

5 participants