Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow accessing send queue count from WebSocketConnection #1156

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Oct 7, 2024

Allows derived classes to check the send queue count and override SendMessageAsync in case the number of messages in the outbound queue is growing out of control. Perhaps in the future backpressure options will be available as a built-in feature, but with #1154 it should not be necessary.

@Shane32 Shane32 added this to the 8.1.0 milestone Oct 7, 2024
@Shane32 Shane32 requested a review from gao-artur October 7, 2024 04:52
@Shane32 Shane32 self-assigned this Oct 7, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (a84c553) to head (9d25258).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1156      +/-   ##
==========================================
- Coverage   90.88%   90.79%   -0.10%     
==========================================
  Files          50       50              
  Lines        2425     2433       +8     
  Branches      432      433       +1     
==========================================
+ Hits         2204     2209       +5     
- Misses        175      176       +1     
- Partials       46       48       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shane32 Shane32 merged commit f5b7b32 into master Oct 20, 2024
7 checks passed
@Shane32 Shane32 deleted the queuecount branch October 20, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants