-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix server readme #6511
base: main
Are you sure you want to change the base?
Fix server readme #6511
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis change reformats the configuration table in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/services/server/README.md (1)
13-13
: Minor terminology improvementsConsider these minor refinements to improve consistency with common technical terminology:
- Line 13: "rate limiting service" → "rate-limiting service"
- Line 23: "User name" → "Username"
Also applies to: 23-23
🧰 Tools
🪛 LanguageTool
[uncategorized] ~13-~13: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ... | The endpoint of the rate limiting service. ...(EN_COMPOUND_ADJECTIVE_INTERNAL)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/services/server/README.md
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`packages/services/**`: Microservices written in NodeJS and ...
packages/services/**
: Microservices written in NodeJS and TypeScript. Most of the dirs under this directory are packages and deployed as Docker packages.
Interaction between services is done using tRPC.
We prefer writing code that does input/output validations with Zod.
The directories that ends with-worker
are projects that are built on top of CloudFlare Workers infrastructure and deployed there.
Thecdn-worker
is a special one, it serves a high-available, detached CDN on CloudFlare Workers. This is how our end-users fetches the crucial data from our platform, in a way that does not depend/couple on our main API (served as GraphQL API).
packages/services/server/README.md
🪛 LanguageTool
packages/services/server/README.md
[uncategorized] ~13-~13: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ... | The endpoint of the rate limiting service. ...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[style] ~23-~23: It’s more common nowadays to write this noun as one word.
Context: ... | User name for accessing the postgres database. ...
(RECOMMENDED_COMPOUNDS)
[uncategorized] ~86-~86: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...emetry Collector endpoint. The expected traces transport is HTTP (port 4318
). ...
(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
🔇 Additional comments (2)
packages/services/server/README.md (2)
7-8
: Well-formatted table structure!The table formatting has been improved with consistent column widths and proper alignment, making it more readable.
88-104
: Well-organized cloud configuration section!The cloud configuration is clearly separated with a helpful disclaimer for self-hosting users.
Background
Table formatting was broken, and I want to read the table.
Description
Not really technical, I simply fixed the formatting of the table. You can test by checking out this branch and seeing it as a formatted markdown document