-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graphql-java
version 22 compatibility
#573
graphql-java
version 22 compatibility
#573
Conversation
…refactor instrumentation
@hiddewie Thank you very much for your time and effort on this PR. The alignment to Before merging it, I would like to remove the unused methods in the DataLoaderDispatchingSpec.groovy test class: |
@federicorispo Thanks for the review! I removed the dead code :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this delicate verison bump 🚀
@federicorispo Is it possible to make a new (major?) version with these changes? |
Yes of course, but first I would like to test the other minor dependency bumps before merge them and release a new major (in a day or two). If you want, you can test the snapshot version <repository>
<id>oss.sonatype.org-snapshot</id>
<url>https://oss.sonatype.org/content/repositories/snapshots</url>
<releases>
<enabled>false</enabled>
</releases>
<snapshots>
<enabled>true</enabled>
</snapshots>
</repository> |
Perfect, thank you! |
Hi @federicorispo, did you manage to release a new version so I can update all my projects using normal versions instead of snapshot versions? I don't see it listed in https://github.com/graphql-java-kickstart/graphql-java-servlet/releases. Thanks! |
@hiddewie Hi, I released the version 16.0.0 of the graphql-java-servlet with the graphql-java version 22.3 |
Thanks a lot! |
This PR makes the project compatible with GraphQL Java version 22
Changes:
com.graphql-java:graphql-java
version 22DataLoaderDispatcherInstrumentation
relatedRef graphql-java/graphql-java#3447, which has most impact on this pull request.