Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "editorial changes" to CONTRIBUTING.md #1141

Merged
merged 5 commits into from
Feb 27, 2025
Merged

Add "editorial changes" to CONTRIBUTING.md #1141

merged 5 commits into from
Feb 27, 2025

Conversation

martinbonnin
Copy link
Contributor

Trying to document the way we operate. I don't think we have anything like this already?

See also #1136 (comment)

Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit 078a7c9
🔍 Latest deploy log https://app.netlify.com/sites/graphql-spec-draft/deploys/67c080fcfac4f90008d3c473
😎 Deploy Preview https://deploy-preview-1141--graphql-spec-draft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@benjie
Copy link
Member

benjie commented Feb 27, 2025

There is the second paragraph in the document:

Contributions that do not change the interpretation of the spec but instead
improve legibility, fix editorial errors, clear up ambiguity and improve
examples are encouraged and are often merged by a spec editor with little
process.

@martinbonnin
Copy link
Contributor Author

There is the second paragraph in the document:

Woops! Thanks!

@martinbonnin martinbonnin reopened this Feb 27, 2025
@martinbonnin
Copy link
Contributor Author

Actually, the way I did it was to grep for "editorial changes" in both graphql-wg and graphql-spec. I think there is some value in using the term as it's relatively used in the working groups?

Another thing that could be interesting to add in is the definition of an "editor". Is it someone with write access to the repository? Something else? How is that different from the TSC? Do we have that somewhere?

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's link to the label too 👍

@benjie benjie merged commit 3c02659 into main Feb 27, 2025
9 checks passed
@benjie benjie deleted the editorial-change branch February 27, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants