Add major version to go module name #46
Conversation
hugoShaka
requested review from
klizhentas,
russjones and
r0mant
as code owners
hugoShaka
changed the title
| @@ -1,4 +1,4 @@ | |||
| module github.com/gravitational/protoc-gen-terraform | |||
| module github.com/gravitational/protoc-gen-terraform/v3 | |||
|
|
|||
| go 1.18 | |||
There was a problem hiding this comment.
Yeah, this repo does not receive much love. On the other hand I don't see why we should increase the go version if we are not forced by a dependency. Lowest versions offer better compatibility.
There was a problem hiding this comment.
I wonder if we should move it to be near the terraform provider, just like we have the crd generator
There was a problem hiding this comment.
This code is not maintained a lot today and I don't think we can bump all the dependencies. If we vendor it, we'll have to appease all the security checks, linters and other dependency checkers. I'm happy to keep it outside for now, like the https://github.com/gravitational/terraform-plugin-docs
There was a problem hiding this comment.
Also it seems some people outside of Teleport are using the protoc plugin to generate provider
This PR adds the major verison to the module name so specific version can be installed with
go installdirectly.I will create a tag for v3.0.1 after merging this PR.
You can test by running
Fixes #37 starting with 3.0.1