Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump asciidoctor to 3.0.2 #672

Merged
merged 1 commit into from
Dec 15, 2023
Merged

feat: bump asciidoctor to 3.0.2 #672

merged 1 commit into from
Dec 15, 2023

Conversation

ThibaudAV
Copy link
Contributor

@ThibaudAV ThibaudAV commented Dec 14, 2023 •
edited
Loading

Issue

Needed for apim with Angular 14 and Angular CLI

Description

  • Tested with apim 3.20
  • Tested with apim master

Additional context

📚  View the storybook of this branch here

@graviteeio
Copy link
Contributor

graviteeio commented Dec 14, 2023 •
edited
Loading

Hey dear reviewer, I'm the Gravitee.io bot 🤖

I just want to tell you that package.json has been updated in this PR.

Some components are based on third party libraries, for integration into a web component, we extract the css from its libraries as assets.

WARNING: When highlight.js or github-markdown-css are updated, we must run yarn build task to update the css.

Generated by 🚫 dangerJS against e5b7f69

@graviteeio
Copy link
Contributor

Gravitee.io Automatic Deployment

A beta version of this package has been published! 🚀

To use it in your project run the following lines:

npm install @gravitee/[email protected]

or

yarn add @gravitee/[email protected]

@ThibaudAV ThibaudAV marked this pull request as ready for review December 14, 2023 14:47
@ThibaudAV ThibaudAV requested a review from a team as a code owner December 14, 2023 14:47
@ThibaudAV ThibaudAV force-pushed the bump-asciidoctor branch 2 times, most recently from 7ad9932 to 46365fa Compare December 14, 2023 15:01
@graviteeio
Copy link
Contributor

Gravitee.io Automatic Deployment

A beta version of this package has been published! 🚀

To use it in your project run the following lines:

npm install @gravitee/[email protected]

or

yarn add @gravitee/[email protected]

@ThibaudAV ThibaudAV requested a review from a team December 14, 2023 15:25
@graviteeio
Copy link
Contributor

Gravitee.io Automatic Deployment

A beta version of this package has been published! 🚀

To use it in your project run the following lines:

npm install @gravitee/[email protected]

or

yarn add @gravitee/[email protected]

@ThibaudAV ThibaudAV enabled auto-merge (rebase) December 15, 2023 10:16
@graviteeio
Copy link
Contributor

Gravitee.io Automatic Deployment

A beta version of this package has been published! 🚀

To use it in your project run the following lines:

npm install @gravitee/[email protected]

or

yarn add @gravitee/[email protected]

@ThibaudAV
feat: bump asciidoctor to 3.0.2
e5b7f69 
BREAKING CHANGE: The @asciidoctor/core & asciidoctor dependency are now in version ^3.0.2.
Note: npm is likely to return a warring because asciidoctor-highlight.js continues to require
version 2.x of asciidoctor. We can ignore this error `--force`
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@graviteeio
Copy link
Contributor

Gravitee.io Automatic Deployment

A beta version of this package has been published! 🚀

To use it in your project run the following lines:

npm install @gravitee/[email protected]

or

yarn add @gravitee/[email protected]

@ThibaudAV ThibaudAV merged commit d3327f2 into master Dec 15, 2023
3 checks passed
@ThibaudAV ThibaudAV deleted the bump-asciidoctor branch December 15, 2023 10:45
@graviteeio
Copy link
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loriepisicchio loriepisicchio loriepisicchio approved these changes

@gaetanmaisse gaetanmaisse gaetanmaisse approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThibaudAV @graviteeio @loriepisicchio @gaetanmaisse