-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add about and getting started docs #2838
base: develop
Are you sure you want to change the base?
Conversation
docs/guides/introduction/about.md
Outdated
@@ -1 +1,24 @@ | |||
# About Daffodil | |||
|
|||
Daffodil is a client-side framework for building ecommerce stores. It presents a standard set of interfaces with which the frontend application can interact while offering a selection of drivers that communicate with the platform of choice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Daffodil is a client-side framework for building ecommerce stores. It presents a standard set of interfaces with which the frontend application can interact while offering a selection of drivers that communicate with the platform of choice. | |
Daffodil is a client-side framework for building ecommerce stores. It presents a standard set of interfaces with which the frontend application can interact with, along with a selection of drivers that communicate with the platform of choice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be grammatically incorrect with the double "with". I changed the wording to be closer to your suggestion though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's grammatically incorrect?
It presents a standard set of interfaces with which the frontend application can interact.
This sentence definitely needs a with at the end.
If you don't like the double with, it can be:
It presents a standard set of interfaces for frontend applications to interact with, in addition to a selection of drivers that communicate with your platform of choice.
It presents a standard set of interfaces for frontend applications to interact with, along with a selection of drivers that communicate with your platform of choice.
It presents a standard set of interfaces for frontend applications to interact with. It also includes a selection of drivers that communicate with your platform of choice.
Shortened It presents a standard set of interfaces with which the frontend application
to It presents a standard set of interfaces for frontend applications
to reduce the triple with
Co-authored-by: Elain T. <[email protected]>
Co-authored-by: Elain T. <[email protected]>
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Other information
fixes: #2835