Fix board revision detection in firmware #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we added a fixed value to the ADC reading before right-shifting. This corrected truncation error, allowing integer comparison values to match a whole percentage number in the table of expected ranges. This correction worked when gsg_production was true, but it was incorrect in the other case. We now do the math with per mille values rather than percent values, so it is simpler to eliminate the truncation correction and instead compare against an expected value between two whole percents. For example, we compare the per mille value with 225 to determine whether it is closer to 22 percent or 23 percent.
mndza
reviewed
Aug 1, 2024
mndza
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gsg_productionboardsI believe the double ADC read is the correct fix for greatscottgadgets/cynthion#138. A previous fix in #109 may have been unnecessary, but we will keep it for now to be safe.