Fix "non-context-aware" error for Electron #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced NODE_MODULE with NAN_MODULE_WORKER_ENABLED to fix issues with the latest electron releases.
|
That looks nice, if only there was still a maintainer alive on this project to merge PR 😄 P.S. I confirm that electron 14 on windows 10 (x64) with the nightly build it crash, with this patch it works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #264 (and possibly #297 since crashing is what occurs currently with Greenworks on later Electron releases).
The latest releases of Electron prevent "non-context-aware" native modules. By Replacing
NODE_MODULEwithNAN_MODULE_WORKER_ENABLEDthis fixes the errors for Electron.