Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor issues #86

Merged
merged 8 commits into from
Mar 22, 2019
Merged

Fix minor issues #86

merged 8 commits into from
Mar 22, 2019

Conversation

MarcoCouto
Copy link

This PR fixes Issues #40 and #74.

It also includes a small update on the LogUtils class, to reflect the changes included in the new target API version, namely:

  • the max length of the log tag changed to 23 instead of.
  • before logging anything, there should be a check for message != null; the app was crashing because of it.

@MarcoCouto MarcoCouto requested a review from hmatalonga March 22, 2019 17:17
@hmatalonga
Copy link
Member

This closes #40 and closes #74

@hmatalonga hmatalonga merged commit b0956b4 into 1.2 Mar 22, 2019
@hmatalonga hmatalonga deleted the mc-minor_fixes branch March 22, 2019 19:06
hmatalonga added a commit that referenced this pull request Oct 4, 2019
* Add CODEOWNERS file

* Added new configuration settings

* Added support for battery remaining time estimation

* Updated database

* Added support for representation of remaining battery time

* changed approach to improve the accuracy when switching from charging to battery

* fixed codacy issues

* fix codacy issues

* SAVEPOINT

* Add missing translation to pt values

* SAVEPOINT

* DataEstimator code cleanup

* Prevent Inspector of creating new sample if is already sampling, to avoid duplicates battery values. Fixes #75

* Add additional validation for upload attempts after failed too many times in order to reset the state. Temporary fixes #77

* Add task to delete old samples

* Integrate checkstyle to follow  AOSP code guidelines. Bump Android SDK version. Closes #27

* Fix some codacy issues

* Fix some codacy issues #2

* Update README.md and related docs

* Remove duplicated information in the README.md file

* Add development setup instructions

* SAVEPOINT

* reimplement sampling logic to avoid using explicit wakelocks

* move battery changes broadcast receiver to independent service

* update minSdkVersion to reflect the use of JobScheduler

* fix checkstyle issues

* remove unused variable

* Fix minor issues (#86)

* update memory usage calculation method

* remove status notification

* fix log issues

* update memory usage calculation method

* remove status notification

* fix log issues

* fix style issues

* Feature/sersors details (#89)

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* Feature/sersors details (#90)

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* UI Sensors

* UI sensors

* Checkstyle issues

* UI Sensors Data

* UI Sensors Data

* New features for Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* New version with Sensors Data

* chore: update dependencies

* feat: add processutils class for legacy versions

* refactor: bump min android supported version

* chore: add exception handling for start service illegal state

* refactor: fix minor issues

* chore: bump android sdk of travis build

* chore: accept build-tools license for travis build

* chore: remove checkstyle task from travis build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants